fix(l1,l2): fix encoding of nodes in witness #5421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a double encoding bug in the debug_executionWitness RPC endpoint where trie nodes were being RLP-encoded twice before being returned in the witness response.
- Removes redundant RLP encoding of trie nodes in witness generation
- Cleans up unused
RLPEncodeimport - Ensures compatibility with ethrex-replay tool by returning properly encoded witness data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ilitteri
approved these changes
Nov 25, 2025
MegaRedHand
approved these changes
Nov 25, 2025
LeanSerra
pushed a commit
that referenced
this pull request
Nov 26, 2025
**Motivation** - Fix `debug_executionWitness` endpoint **Description** <!-- A clear and concise general description of the changes this PR introduces --> - When asking for the witness of a block the trie nodes were being encoded 2 times (double encoding). This just removes the additional encoding. This has been tested with ethrex-replay and now it works perfectly fine with ethrex nodes. We were getting errors decoding RLP before. How to test it? - Run L1 in dev mode - Request witness with debug_executionWitness See the response both in main and in this branch, you'll see that the nodes are "the same" but in main they are encoded one more time. Basically in main: `RLP(RLP(node))`, but here: `RLP(node)`. We want the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
debug_executionWitnessendpointDescription
This has been tested with ethrex-replay and now it works perfectly fine with ethrex nodes. We were getting errors decoding RLP before.
How to test it?
See the response both in main and in this branch, you'll see that the nodes are "the same" but in main they are encoded one more time. Basically in main:
RLP(RLP(node)), but here:RLP(node). We want the latter.