-
Notifications
You must be signed in to change notification settings - Fork 146
docs(l1,l2): add steps to manually push docker images #5420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,3 +130,41 @@ Once the release is verified, **merge the branch via PR**. | |
| ## Dealing with hotfixes | ||
|
|
||
| If hotfixes are needed before the final release, commit them to `release/vX.Y.Z`, push, and create a new pre-release tag. The final tag `vX.Y.Z` should always point to the exact commit you will merge via PR. | ||
|
|
||
| ## Troubleshooting | ||
|
|
||
| ### Failure on "latest release" workflow | ||
|
|
||
| If the CI fails when setting a release as latest (step 4), Docker tags `latest` and `l2` may not be updated. To manually push that changes, follow these steps: | ||
|
|
||
| - Create a new Github Personal Access Token (PAT) from the [settings](https://github.com/settings/tokens/new). | ||
| - Check `write:packages` permission (this will auto-check `repo` permissions too), give a name and a short expiration time. | ||
| - Save the token securely. | ||
| - Click on `Configure SSO` button and authorize LambdaClass organization. | ||
| - Log in to Github Container Registry: `docker login ghcr.io`. Put your Github's username and use the token as your password. | ||
| - Pull RC images: | ||
|
|
||
| ```bash | ||
| docker pull --platform linux/amd64 ghcr.io/lambdaclass/ethrex:X.Y.Z-rc.W | ||
| docker pull --platform linux/amd64 ghcr.io/lambdaclass/ethrex:X.Y.Z-rc.W-l2 | ||
| ``` | ||
|
|
||
| - Retag them: | ||
|
|
||
| ```bash | ||
| docker tag ghcr.io/lambdaclass/ethrex:X.Y.Z-rc.W ghcr.io/lambdaclass/ethrex:X.Y.Z | ||
| docker tag ghcr.io/lambdaclass/ethrex:X.Y.Z-rc.W-l2 ghcr.io/lambdaclass/ethrex:X.Y.Z-l2 | ||
| docker tag ghcr.io/lambdaclass/ethrex:X.Y.Z-rc.W ghcr.io/lambdaclass/ethrex:lateset | ||
| docker tag ghcr.io/lambdaclass/ethrex:X.Y.Z-rc.W-l2 ghcr.io/lambdaclass/ethrex:l2 | ||
| ``` | ||
|
|
||
| - Push them: | ||
|
|
||
| ```bash | ||
| docker push ghcr.io/lambdaclass/ethrex:X.Y.Z | ||
| docker push ghcr.io/lambdaclass/ethrex:X.Y.Z-l2 | ||
| docker push ghcr.io/lambdaclass/ethrex:lateset | ||
|
||
| docker push ghcr.io/lambdaclass/ethrex:l2 | ||
| ``` | ||
|
|
||
| - Delete the PAT for security ([here](https://github.com/settings/tokens)) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "lateset" should be "latest".