Skip to content

chore(l1): enhance error rate panels and promote them to its own row #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodrigo-o merged 11 commits into from
Nov 21, 2025
Merged

chore(l1): enhance error rate panels and promote them to its own row #5395

rodrigo-o merged 11 commits into from
Nov 21, 2025

Conversation

@rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Nov 20, 2025 •
edited
Loading

Motivation

Previous success/error rate has too few information to tell what was failing.

Description

This PR add error_kind to the RPC/Engine outcome to be able to tell what failed. We moved both error rates to it's'own row making every other row clearer and added a new panel deagregated by method and error kind.

image

Will close #5379 once in main

@github-actions github-actions bot added the L1 Ethereum client label Nov 20, 2025
@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

Lines of code report

Total lines added: 25
Total lines removed: 0
Total lines changed: 25

Detailed view 
+-----------------------------------------+-------+------+
| File                                    | Lines | Diff |
+-----------------------------------------+-------+------+
| ethrex/crates/blockchain/metrics/rpc.rs | 61    | +6   |
+-----------------------------------------+-------+------+
| ethrex/crates/networking/rpc/rpc.rs     | 873   | +19  |
+-----------------------------------------+-------+------+

@rodrigo-o rodrigo-o marked this pull request as ready for review November 20, 2025 23:17
@rodrigo-o rodrigo-o requested a review from a team as a code owner November 20, 2025 23:17
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Nov 20, 2025
@rodrigo-o rodrigo-o changed the title chore(l1): enhance error rate panels and promete them to its own row chore(l1): enhance error rate panels and promote them to its own row Nov 20, 2025
@rodrigo-o rodrigo-o merged commit 108536d into rpc_error_rates Nov 21, 2025
47 checks passed
@rodrigo-o rodrigo-o deleted the enhance-error-rate-panels branch November 21, 2025 14:28
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rodrigo-o rodrigo-o

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rodrigo-o