-
Notifications
You must be signed in to change notification settings - Fork 131
feat(l2): add ZisK backend #5392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> upload zisk artifact correctly
JereSalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
tomip01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit
| url.workspace = true | ||
| rkyv.workspace = true | ||
| rustc-hash.workspace = true | ||
| k256.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe too nit but I think this should be used optionally with sp1, risc0 or zisk
| # rkyv for ProverInputData, a data structure meant to be used in the host and not | ||
| # inside a guest program | ||
| rkyv.workspace = true | ||
| k256.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
**Motivation** To add ZisK as a new backend for ethrex-prover. **Description** - Implements ZisK guest program and code to build it - Adds ZisK as a new backend to the ethrex-prover SDK - Implements `eip7702_recover_address()` using `k256` to make it compatible with ZisK (and this also optimizes the function for other zkVMs) Closes #issue_number --------- Co-authored-by: ilitteri <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: ilitteri <[email protected]> Co-authored-by: Jeremías Salomón <[email protected]>
**Motivation** a ZisK backend was added for ethrex-prover in lambdaclass/ethrex#5392. This PR adds supports to use it with ethrex-replay --------- Co-authored-by: ilitteri <[email protected]> Co-authored-by: ilitteri <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: JereSalo <[email protected]>
Motivation
To add ZisK as a new backend for ethrex-prover.
Description
eip7702_recover_address()usingk256to make it compatible with ZisK (and this also optimizes the function for other zkVMs)Closes #issue_number