feat(l1): add target and script to run multiple benchmark runs #5368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
added
performance
github-actions
bot
added
L1
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds automation for running multiple benchmark iterations by introducing a shell script and a new Makefile target. The goal is to streamline the process of running repeated import benchmarks with automatic log file numbering.
- Adds
benchmark.shscript to automate multiple benchmark runs with sequential log numbering - Introduces
run-benchesMakefile target as a convenient wrapper for the script - Enables running 3 benchmark iterations by default using the existing benchmark infrastructure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tooling/import_benchmark/benchmark.sh | New shell script that runs multiple benchmark iterations with automatic log file numbering and cleanup |
| tooling/import_benchmark/Makefile | Adds run-benches target to invoke the benchmark script with 3 repetitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benchmark Block Execution Results Comparison Against Main
|
fedacking
reviewed
Nov 16, 2025
mpaulucci
approved these changes
Nov 17, 2025
fedacking
approved these changes
Nov 25, 2025
LeanSerra
pushed a commit
that referenced
this pull request
Nov 26, 2025
This PR improves `tooling/import_benchmark` by adding a target that runs multiple repetitions of the same benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
tooling/import_benchmarkby adding a target that runs multiple repetitions of the same benchmark.