feat(l2): add serde to AuthorizationTuple fields #5339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
damiramirez
changed the title
damiramirez
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds custom serde deserializers to AuthorizationTuple fields to enable JavaScript compatibility through the L2 Hub. The deserializers handle both hexadecimal and decimal string representations, addressing parsing failures when JavaScript sends values like "0x0" instead of numeric types.
Key changes:
- Added
deser_hex_or_dec_strdeserializers to U256 fields (chain_id, y_parity, r_signature, s_signature) - Added
deser_hex_or_dec_strdeserializer withdefaultattribute to the nonce field (u64) - Minor whitespace fix in genesis file
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/common/types/tx_fields.rs | Added serde deserializers to all AuthorizationTuple fields to parse both hex and decimal string formats |
| fixtures/genesis/l2.json | Added missing newline at end of file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilitteri
approved these changes
Nov 13, 2025
tomip01
approved these changes
Nov 14, 2025
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Nov 17, 2025
**Motivation** Add serde to specific fields of `AuthorizationTuple` **Description** To use the [L2 Hub](https://github.com/lambdaclass/ethrex_l2_hub), we need to parse the fields of AuthorizationTuple to make them compatible with JavaScript. ``` Details: Invalid Ethex L2 message: Failed to parse request into ethrex_SendTransaction: invalid type: string "0x0", expected u64 Version: [email protected] at getContractError (chunk-7ZVOX3I3.js?v=69061873:218:10) at writeContract (chunk-UOLTLXVA.js?v=69061873:587:11) at async signUp (passkeyAccounts.ts:55:16) at async handleSignUp (AccountCard.tsx:28:46)Caused by: TransactionExecutionError: RPC Request failed. ``` --------- Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
ricomateo
pushed a commit
that referenced
this pull request
Nov 18, 2025
**Motivation** Add serde to specific fields of `AuthorizationTuple` **Description** To use the [L2 Hub](https://github.com/lambdaclass/ethrex_l2_hub), we need to parse the fields of AuthorizationTuple to make them compatible with JavaScript. ``` Details: Invalid Ethex L2 message: Failed to parse request into ethrex_SendTransaction: invalid type: string "0x0", expected u64 Version: [email protected] at getContractError (chunk-7ZVOX3I3.js?v=69061873:218:10) at writeContract (chunk-UOLTLXVA.js?v=69061873:587:11) at async signUp (passkeyAccounts.ts:55:16) at async handleSignUp (AccountCard.tsx:28:46)Caused by: TransactionExecutionError: RPC Request failed. ``` --------- Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add serde to specific fields of
AuthorizationTupleDescription
To use the L2 Hub, we need to parse the fields of AuthorizationTuple to make them compatible with JavaScript.