fix(l2): revert breaking when budget is reached for privileged txs #5326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that caused integration tests to run longer and require more retries. The change replaces a break statement with txs.pop(); continue; when the privileged transaction budget is reached, allowing the block producer to continue processing other transactions instead of stopping entirely.
- Reverted logic from breaking to continuing when privileged transaction budget is reached
- Added an issue reference for properly addressing the underlying problem later
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lines of code reportTotal lines added: Detailed view |
avilagaston9
approved these changes
Nov 13, 2025
ManuelBilbao
approved these changes
Nov 13, 2025
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Nov 17, 2025
…ambdaclass#5326) **Motivation** [This](lambdaclass#5135 (comment)) change made the integration tests took longer, having to amp the amount of retries. <!-- Why does this pull request exist? What are its goals? --> **Description** Reverts this change and adds an [issue](lambdaclass#5325) for solving it. <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change made the integration tests took longer, having to amp the amount of retries.
Description
Reverts this change and adds an issue for solving it.