-
Notifications
You must be signed in to change notification settings - Fork 155
feat(l1): add CLI flag to specify P2P listening address #5297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ad65a42
feat(l1): add CLI flag to specify P2P listening address
MegaRedHand 7783339
Merge branch 'main' into add-p2p-addr-flag
MegaRedHand 2b02000
docs: update CLI reference
MegaRedHand d0cc31d
Merge branch 'main' into add-p2p-addr-flag
MegaRedHand 8de9f8a
docs: update CLI reference
MegaRedHand 1d6236c
Merge branch 'main' into add-p2p-addr-flag
MegaRedHand d68e823
Merge branch 'main' into add-p2p-addr-flag
MegaRedHand 6cd322e
docs: update CLI reference (this time for real)
MegaRedHand 197a715
docs: add --sp1-server option to reference
MegaRedHand e09830e
Merge branch 'main' into add-p2p-addr-flag
MegaRedHand d4afddb
Update cmd/ethrex/cli.rs
MegaRedHand ac66b34
Merge branch 'main' into add-p2p-addr-flag
MegaRedHand 0fd997f
Merge branch 'main' into add-p2p-addr-flag
MegaRedHand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,8 +79,11 @@ P2P options: | |
| --p2p.disabled | ||
|
|
||
|
|
||
| --p2p.addr <ADDRESS> | ||
| Listening address for the P2P protocol. | ||
|
|
||
| --p2p.port <PORT> | ||
| TCP port for P2P protocol. | ||
| TCP port for the P2P protocol. | ||
|
|
||
| [default: 30303] | ||
|
|
||
|
|
@@ -176,6 +179,11 @@ Commands: | |
| help Print this message or the help of the given subcommand(s) | ||
|
|
||
| Options: | ||
| --osaka-activation-time <UINT64> | ||
| Block timestamp at which the Osaka fork is activated on L1. If not set, it will assume Osaka is already active. | ||
|
|
||
| [env: ETHREX_OSAKA_ACTIVATION_TIME=] | ||
|
|
||
| -t, --tick-rate <TICK_RATE> | ||
| time in ms between two ticks | ||
|
|
||
|
|
@@ -242,8 +250,11 @@ P2P options: | |
| --p2p.disabled | ||
|
|
||
|
|
||
| --p2p.addr <ADDRESS> | ||
| Listening address for the P2P protocol. | ||
|
|
||
| --p2p.port <PORT> | ||
| TCP port for P2P protocol. | ||
| TCP port for the P2P protocol. | ||
|
|
||
| [default: 30303] | ||
|
|
||
|
|
@@ -369,6 +380,10 @@ L1 Watcher options: | |
| [default: 10] | ||
|
|
||
| Block producer options: | ||
| --watcher.l1-fee-update-interval-ms <ADDRESS> | ||
| [env: ETHREX_WATCHER_L1_FEE_UPDATE_INTERVAL_MS=] | ||
| [default: 60000] | ||
|
|
||
| --block-producer.block-time <UINT64> | ||
| How often does the sequencer produce new blocks to the L1 in milliseconds. | ||
|
|
||
|
|
@@ -384,11 +399,14 @@ Block producer options: | |
| --block-producer.operator-fee-vault-address <ADDRESS> | ||
| [env: ETHREX_BLOCK_PRODUCER_OPERATOR_FEE_VAULT_ADDRESS=] | ||
|
|
||
| --operator-fee-per-gas <UINT64> | ||
| --block-producer.operator-fee-per-gas <UINT64> | ||
| Fee that the operator will receive for each unit of gas consumed in a block. | ||
|
|
||
| [env: ETHREX_BLOCK_PRODUCER_OPERATOR_FEE_PER_GAS=] | ||
|
|
||
| --block-producer.l1-fee-vault-address <ADDRESS> | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some options weren't updated since they're not checked in the CI |
||
| [env: ETHREX_BLOCK_PRODUCER_L1_FEE_VAULT_ADDRESS=] | ||
|
|
||
| --block-producer.block-gas-limit <UINT64> | ||
| Maximum gas limit for the L2 blocks. | ||
|
|
||
|
|
@@ -553,7 +571,6 @@ L2 options: | |
| Monitor options: | ||
| --no-monitor | ||
| [env: ETHREX_NO_MONITOR=] | ||
|
|
||
| ``` | ||
|
|
||
| ## ethrex l2 prover | ||
|
|
@@ -589,11 +606,6 @@ Prover client options: | |
|
|
||
| [default: INFO] | ||
|
|
||
| --aligned | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This option was moved, but wasn't removed from here. |
||
| Activate aligned proving system | ||
|
|
||
| [env: PROVER_CLIENT_ALIGNED=] | ||
|
|
||
| --sp1-server <URL> | ||
| Url to the moongate server to use when using sp1 backend | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.