perf(levm): cache BLOBBASEFEE opcode value
#5288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
levm
Lines of code reportTotal lines added: Detailed view |
Benchmark Results ComparisonNo significant difference was registered for any benchmark run. Detailed ResultsBenchmark Results: BubbleSort
Benchmark Results: ERC20Approval
Benchmark Results: ERC20Mint
Benchmark Results: ERC20Transfer
Benchmark Results: Factorial
Benchmark Results: FactorialRecursive
Benchmark Results: Fibonacci
Benchmark Results: FibonacciRecursive
Benchmark Results: ManyHashes
Benchmark Results: MstoreBench
Benchmark Results: Push
Benchmark Results: SstoreBench_no_opt
|
Benchmark Block Execution Results Comparison Against Main
|
Arkenan
approved these changes
Nov 12, 2025
Collaborator
Arkenan
left a comment
Arkenan
left a comment
There was a problem hiding this comment.
Nice catch. Left one optional comment.
|
|
||
| let blob_base_fee = | ||
| get_base_fee_per_blob_gas(self.env.block_excess_blob_gas, &self.env.config)?; | ||
| let blob_base_fee = match self.blob_base_fee.get() { |
Collaborator
There was a problem hiding this comment.
nit: is this not a bit clearer if we use OnceCell::get_or_init?
Contributor
Author
There was a problem hiding this comment.
Does not work because it can't handle errors. The get_or_try_init method is nightly-only.
Contributor
There was a problem hiding this comment.
Not as much a nit, is needing the blob_base_fee uncommon enough to not just init it with the block, rather than using a OnceCell?
Besides, we already have a &mut self here, so we could just use an option in any case.
Oppen
approved these changes
Nov 12, 2025
Contributor
Oppen
left a comment
Oppen
left a comment
There was a problem hiding this comment.
Ok in principle, before or after merge I'd like to discuss what I commented on. Can be handled later in a separate PR.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
**Motivation** Currently in prepare_execution we are, for each transaction, calculating the blob base fee which is consistent across the block. **Description** This was already cached for `BLOBBASEFEE` in #5288, but it could be unified across all users by making part of the Environment. --------- Co-authored-by: Tomás Grüner <[email protected]>
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Nov 17, 2025
…aclass#5328) **Motivation** Currently in prepare_execution we are, for each transaction, calculating the blob base fee which is consistent across the block. **Description** This was already cached for `BLOBBASEFEE` in lambdaclass#5288, but it could be unified across all users by making part of the Environment. --------- Co-authored-by: Tomás Grüner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our implementation of
BLOBBASEFEEis slow when compared to any other client.Description
The
BLOBBASEFEEvalue should not change between runs with the same block header and environment, therefore it can be cached and reused.