-
Notifications
You must be signed in to change notification settings - Fork 130
perf(l1): selective dirtying of trie #5282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark for 6a52787Click to view benchmark
|
Benchmark for 2a3c495Click to view benchmark
|
Benchmark for a2962a1Click to view benchmark
|
Benchmark Block Execution Results Comparison Against Main
|
Benchmark for faf95d6Click to view benchmark
|
Benchmark for 0164775Click to view benchmark
|
Benchmark for 2912687Click to view benchmark
|
Benchmark for 794c259Click to view benchmark
|
MegaRedHand
reviewed
Nov 12, 2025
pablodeymo
approved these changes
Nov 12, 2025
Oppen
approved these changes
Nov 12, 2025
MegaRedHand
approved these changes
Nov 12, 2025
Benchmark for 668e621Click to view benchmark
|
Benchmark for 6c37c90Click to view benchmark
|
This reverts commit cf4ce43.
Benchmark for 03a3fbeClick to view benchmark
|
Benchmark for adcd587Click to view benchmark
|
Benchmark for 16f96d4Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently doing merkelization we do trie-traversal to avoid reading stale FKVs, marking the trie as dirty the first time it's changed. However, this could be done on a per-key basis.
Description
Keeps track of modified keys in a trie and does traversal for those.