perf(levm): fix FlatKeyValue generation on full sync mode
#5274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
levm
Lines of code reportTotal lines added: Detailed view |
Benchmark Block Execution Results Comparison Against Main
|
jrchatruc
approved these changes
Nov 11, 2025
MegaRedHand
approved these changes
Nov 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the FlatKeyValue generation process for full sync mode by ensuring it's triggered after loading the genesis state, addressing a missing step that prevented proper database indexing during benchmarks.
- Added a call to
store.generate_flatkeyvalue()after store initialization when running in full sync mode - Updated CHANGELOG.md to document the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/ethrex/initializers.rs | Added conditional call to generate FlatKeyValue in full sync mode after store initialization |
| CHANGELOG.md | Added entry documenting the fix with minor formatting adjustments to other entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** The `FlatKeyValue` isn't being generated when running the benchmarks. **Description** Generate the `FlatKeyValue` after loading the genesis state when starting in fullsync mode. --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
FlatKeyValueisn't being generated when running the benchmarks.Description
Generate the
FlatKeyValueafter loading the genesis state when starting in fullsync mode.