feat(l1): improve block execution aggregation logs #5260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the clarity of block execution aggregation logs by restructuring percentage calculations to avoid confusion where percentages didn't sum to 100%.
Key changes:
- Renamed
merkle_end_instantto_merkle_end_instantto indicate it's not directly used in the new log format - Restructured the log format to show sequential phases with better separators
- Adjusted percentage calculations to show: block validation, exec (with concurrent merkle), merkle-only phase, and storage phases
Comments suppressed due to low confidence (1)
crates/blockchain/blockchain.rs:1
- Missing opening parenthesis before 'max_queue_length'. The format string has '(max_queue_length:' but should have both opening and closing parentheses around the entire clause. Change to '(max_queue_length: {merkle_queue_length})'.
pub mod constants;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SDartayet
approved these changes
Nov 11, 2025
fmoletta
approved these changes
Nov 12, 2025
tomip01
pushed a commit
that referenced
this pull request
Nov 12, 2025
**Motivation** Current block execution logs are a bit confusing, since percentages don't sum to 100%. **Description** This PR changes the block execution logs from: ```text 2025-11-11T16:38:49.782644Z INFO [METRIC] BLOCK EXECUTION THROUGHPUT (1600202): 0.333 Ggas/s TIME SPENT: 59 ms. Gas Used: 0.020 (33%), #Txs: 490. block validation: 0% exec+merkle: 98% (exec: 87% merkle: 98% max_queue_length: 363) store: 2% ``` to: ```text 2025-11-11T16:38:49.782644Z INFO [METRIC] BLOCK EXECUTION THROUGHPUT (1600202): 0.333 Ggas/s TIME SPENT: 59 ms. Gas Used: 0.020 (33%), #Txs: 490. block validation: 0% | exec(w/merkle): 87% | merkle-only: 11% (max_queue_length: 363) | store: 2% ``` --------- Co-authored-by: Ivan Litteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current block execution logs are a bit confusing, since percentages don't sum to 100%.
Description
This PR changes the block execution logs from:
to: