feat(l1): log warning if no CL messages are received in a while #5256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
SDartayet
changed the title
Log an error message if no messages are received from the consensus layer.
SDartayet
commented
Nov 10, 2025
SDartayet
changed the title
Removed 'warn' from tracing imports in rpc.rs
mpaulucci
reviewed
Nov 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a watchdog mechanism to detect and log warnings when no messages from the consensus layer are received within 30 seconds, helping users identify connectivity issues between Ethrex and the consensus client.
- Added a watch channel-based timer that resets on each auth RPC request
- Spawned a monitoring task that logs an error with troubleshooting hints after 30 seconds of inactivity
- Modified the auth RPC handler to send notifications through the watch channel
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crates/networking/rpc/rpc.rs
Outdated
Comment on lines
305
to
308
| if result.is_err() { | ||
| error!("No messages from the consensus layer. Is the consensus client running? | ||
| Check the auth JWT coincides with the one used by the CL and the auth RPC address and port used by it and Ethrex match." | ||
| ); |
There was a problem hiding this comment.
The spawned task will panic if the sender is dropped. When timer_receiver.changed() returns an error (which occurs when all senders are dropped), the code logs an error but continues looping. This will cause continuous error logging. The loop should break when changed() returns Err, which indicates the channel is closed.
Suggested change
| if result.is_err() { | |
| error!("No messages from the consensus layer. Is the consensus client running? | |
| Check the auth JWT coincides with the one used by the CL and the auth RPC address and port used by it and Ethrex match." | |
| ); | |
| match result { | |
| Ok(Ok(_)) => { | |
| // Successfully received a change, continue looping. | |
| } | |
| Ok(Err(_)) | Err(_) => { | |
| error!("No messages from the consensus layer. Is the consensus client running? | |
| Check the auth JWT coincides with the one used by the CL and the auth RPC address and port used by it and Ethrex match." | |
| ); | |
| break; | |
| } |
Collaborator
There was a problem hiding this comment.
this should be addressed?
SDartayet
changed the title
Co-authored-by: Copilot <[email protected]>
MegaRedHand
approved these changes
Nov 17, 2025
mpaulucci
approved these changes
Nov 25, 2025
LeanSerra
pushed a commit
that referenced
this pull request
Nov 26, 2025
**Motivation** Making it clearer when the client isn't working properly **Description** This PR adds an extra thread which keeps track of whether a message from the consensus layer hasn't been received in the past 30 seconds. This is done by having the auth RPC handler communicate with it when a new message is received to reset the countdown. If no messages have been received after 30 seconds, a message is printed to warn the user, along with some hints as to possible reasons why Ethrex isn't detecting the consensus client. Closes [#5234](#5234) --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Making it clearer when the client isn't working properly
Description
This PR adds an extra thread which keeps track of whether a message from the consensus layer hasn't been received in the past 30 seconds. This is done by having the auth RPC handler communicate with it when a new message is received to reset the countdown. If no messages have been received after 30 seconds, a message is printed to warn the user, along with some hints as to possible reasons why Ethrex isn't detecting the consensus client.
Closes #5234