Skip to content

chore(l1): remove unneeded clone of key in difflayers #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrchatruc merged 1 commit into from
Nov 10, 2025
Merged

chore(l1): remove unneeded clone of key in difflayers #5251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions crates/storage/trie_db/layering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ impl TrieLayerCache {
.inspect_err(|e| tracing::warn!("could not create trie layering bloom filter {e}"))
}

pub fn get(&self, state_root: H256, key: Nibbles) -> Option<Vec<u8>> {
let key = key.as_ref();

pub fn get(&self, state_root: H256, key: &[u8]) -> Option<Vec<u8>> {
// Fast check to know if any layer may contains the given key.
// We can only be certain it doesn't exist, but if it returns true it may or not exist (false positive).
if let Some(filter) = &self.bloom
Expand Down Expand Up @@ -221,7 +219,7 @@ impl TrieDB for TrieWrapper {
}
fn get(&self, key: Nibbles) -> Result<Option<Vec<u8>>, TrieError> {
let key = apply_prefix(self.prefix, key);
if let Some(value) = self.inner.get(self.state_root, key.clone()) {
if let Some(value) = self.inner.get(self.state_root, key.as_ref()) {
return Ok(Some(value));
}
self.db.get(key)
Expand Down
Loading