-
Notifications
You must be signed in to change notification settings - Fork 157
chore(l2): include zkVM ELFs and VKs in the releases #5244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
55326df
b0ac68e
9b81c0b
09c7e93
941ac61
9197dec
a546d85
afeef14
48b6a4a
29c1703
3510728
918c561
e1e5ba0
42db4fe
f7f8464
0d0073d
57351d2
5e55a28
316586f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -149,6 +149,69 @@ jobs: | |||||||||
| name: verification_keys | ||||||||||
| path: verification_keys/ | ||||||||||
|
|
||||||||||
| # There's a separate job to build the guest programs for SP1 and RISC0 since | ||||||||||
| # they need to be built without the l2 features. | ||||||||||
| build-ethrex-guest: | ||||||||||
| strategy: | ||||||||||
| matrix: | ||||||||||
| zkvm: | ||||||||||
| - sp1 | ||||||||||
| - risc0 | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| steps: | ||||||||||
| - name: Checkout code | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: Free Disk Space | ||||||||||
| uses: ./.github/actions/free-disk | ||||||||||
|
|
||||||||||
| - name: Setup Rust Environment | ||||||||||
| uses: ./.github/actions/setup-rust | ||||||||||
|
|
||||||||||
| - name: Install SP1 | ||||||||||
| if: ${{ matrix.zkvm == 'sp1' }} | ||||||||||
| env: | ||||||||||
| SHELL: /bin/bash | ||||||||||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||||||||||
| run: | | ||||||||||
| curl -L https://sp1up.succinct.xyz | bash | ||||||||||
| ~/.sp1/bin/sp1up --version 5.0.8 | ||||||||||
|
|
||||||||||
| - name: Install RISC0 | ||||||||||
| if: ${{ matrix.zkvm == 'risc0' }} | ||||||||||
| env: | ||||||||||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||||||||||
| run: | | ||||||||||
| curl -L https://risczero.com/install | bash | ||||||||||
| ~/.risc0/bin/rzup install cargo-risczero 3.0.3 | ||||||||||
| ~/.risc0/bin/rzup install risc0-groth16 | ||||||||||
| ~/.risc0/bin/rzup install rust | ||||||||||
|
|
||||||||||
| - name: Build ethrex ${{ matrix.zkvm }} elf | ||||||||||
| run: | | ||||||||||
| cargo build --release --package guest_program --features ${{ matrix.zkvm }} | ||||||||||
| mkdir -p ${{ matrix.zkvm }}_verification_keys | ||||||||||
| if [ "${{ matrix.zkvm }}" = "sp1" ]; then | ||||||||||
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-succinct-zkvm-elf ethrex-riscv32im-sp1-elf-${{ github.ref_name }} | ||||||||||
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-succinct-zkvm-vk-bn254 ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-sp1-vk-bn254-${{ github.ref_name }} | ||||||||||
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-succinct-zkvm-vk-u32 ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-sp1-vk-u32-${{ github.ref_name }} | ||||||||||
| elif [ "${{ matrix.zkvm }}" = "risc0" ]; then | ||||||||||
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ethrex-riscv32im-risc0-elf-${{ github.ref_name}} | ||||||||||
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-risc0-vk-${{ github.ref_name}} | ||||||||||
|
||||||||||
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ethrex-riscv32im-risc0-elf-${{ github.ref_name}} | |
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-risc0-vk-${{ github.ref_name}} | |
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ethrex-riscv32im-risc0-elf-${{ github.ref_name }} | |
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-risc0-vk-${{ github.ref_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed since it is required in package-ethrex-guest
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the pattern needs to be instead "*_verification_keys/*"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put VKs and ELFs in a .tar file so we don't add 5 more files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.