refactor(l1): change p2p_enabled flag to p2p_disabled flag #5228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
cdiielsi
commented
Nov 6, 2025
| authrpc_addr: "localhost".into(), | ||
| authrpc_port: "8551".into(), | ||
| authrpc_jwtsecret: "jwt.hex".into(), | ||
| p2p_enabled: true, |
Contributor
Author
There was a problem hiding this comment.
I opted for implementing the opposite behaviour to this and have p2p_disable be set with the default value false, but isn't it that p2p isn't necessary for L2? Shouldn't I set p2p_disabled: true?
Contributor
There was a problem hiding this comment.
I'm pretty sure L2 does require P2P, since the P2P module has an RLPX module related to L2 P2P networking
SDartayet
approved these changes
Nov 7, 2025
| authrpc_addr: "localhost".into(), | ||
| authrpc_port: "8551".into(), | ||
| authrpc_jwtsecret: "jwt.hex".into(), | ||
| p2p_enabled: true, |
Contributor
There was a problem hiding this comment.
I'm pretty sure L2 does require P2P, since the P2P module has an RLPX module related to L2 P2P networking
ElFantasma
approved these changes
Nov 7, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** `p2p_enabled` is a no op since it's the default configuration, so there's no need for it. **Description** This pr replaces the `p2p_enabled` flag with a `p2p_disabled` flag in case someone wants to disable p2p. Closes #4979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
p2p_enabledis a no op since it's the default configuration, so there's no need for it.Description
This pr replaces the
p2p_enabledflag with ap2p_disabledflag in case someone wants to disable p2p.Closes #4979