Skip to content

feat(l1): upgrade execution breakdown pie chart and add new panels #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodrigo-o merged 22 commits into from
Nov 7, 2025
Merged

feat(l1): upgrade execution breakdown pie chart and add new panels #5220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d443b82
initial tests
rodrigo-o Nov 4, 2025
972462f
Add changes in tracing instrumentation
rodrigo-o Nov 4, 2025
2147724
Merge remote-tracking branch 'origin/main' into execution-breakdown-b…
rodrigo-o Nov 4, 2025
7e79d4e
change increse for irate and fix a name
rodrigo-o Nov 4, 2025
4a1d297
fixed the difference with the calculation of ms
rodrigo-o Nov 4, 2025
e102b28
Added block unit correctly
rodrigo-o Nov 4, 2025
26dd600
try to add the block number unit correctly
rodrigo-o Nov 4, 2025
5c0ed90
Fixed an issue with missing data points and fixed the breakdown pie c…
rodrigo-o Nov 5, 2025
4a12363
fix missing blanks
rodrigo-o Nov 5, 2025
bed28de
removed the old span initialization in apply_updates
rodrigo-o Nov 5, 2025
91ea1c2
Added new panels to showcase the compleate breakdown
rodrigo-o Nov 5, 2025
9fade45
Added instance to title of new panels
rodrigo-o Nov 5, 2025
73db6ce
move block breakdown panels below server info
rodrigo-o Nov 5, 2025
2a3f0c2
Move execution breakdown below execution processing and change repeat…
rodrigo-o Nov 6, 2025
93b0ae4
effectively move the repeated panels to the breakdown eow
rodrigo-o Nov 6, 2025
c16003e
Make labels of the pie chart appear to the right
rodrigo-o Nov 6, 2025
9c4fdbf
go back to previous version and just change the placement of the pie …
rodrigo-o Nov 6, 2025
ee78e3d
reverted name instrumentation changes to tackle them in a future PR
rodrigo-o Nov 6, 2025
3fa951f
remove unused instrument import from store
rodrigo-o Nov 6, 2025
626e552
Fixed one missing changed name
rodrigo-o Nov 6, 2025
26ddf75
Merge branch 'main' into execution-breakdown-by-block
rodrigo-o Nov 6, 2025
92fa529
fix typos
rodrigo-o Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/blockchain/blockchain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,7 @@ impl Blockchain {
})
}

#[instrument(level = "trace", name = "Block DB update", skip_all)]
pub fn store_block(
&self,
block: Block,
Expand Down
3 changes: 1 addition & 2 deletions crates/storage/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ use std::{
sync::Mutex,
};
use std::{fmt::Debug, path::Path};
use tracing::{debug, error, info, instrument};
use tracing::{debug, error, info};
/// Number of state trie segments to fetch concurrently during state sync
pub const STATE_TRIE_SEGMENTS: usize = 2;
/// Maximum amount of reads from the snapshot in a single transaction to avoid performance hits due to long-living reads
Expand Down Expand Up @@ -352,7 +352,6 @@ impl Store {

/// Applies account updates based on the block's latest storage state
/// and returns the new state root after the updates have been applied.
#[instrument(level = "trace", name = "Trie update", skip_all)]
Copy link
Collaborator Author

@rodrigo-o rodrigo-o Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already instrumented at handle_merkleization, if it was intended to be part of the non-pipeline instrumentation, we need to do it in a follow-up.

pub fn apply_account_updates_batch(
&self,
block_hash: BlockHash,
Expand Down
2 changes: 0 additions & 2 deletions crates/storage/store_db/rocksdb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,8 +808,6 @@ impl StoreEngine for Store {
.state_root;
let trie_upd_worker_tx = self.trie_update_worker_tx.clone();

let _span = tracing::trace_span!("Block DB update").entered();

let [
cf_receipts,
cf_codes,
Expand Down
1 change: 0 additions & 1 deletion crates/vm/backends/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ impl Evm {
}
}

#[instrument(level = "trace", name = "Block execution", skip_all)]
Copy link
Collaborator Author

@rodrigo-o rodrigo-o Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not instrumenting other non-pipeline related functions, if we want to do so we might need to do it in a following PR.

pub fn execute_block(&mut self, block: &Block) -> Result<BlockExecutionResult, EvmError> {
LEVM::execute_block(block, &mut self.db, self.vm_type)
}
Expand Down
Loading