refactor(l1): bring all test modules in the rpc crate into a single test_util module #5213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
cdiielsi
changed the title
cdiielsi
changed the title
ElFantasma
approved these changes
Nov 7, 2025
Contributor
ElFantasma
left a comment
ElFantasma
left a comment
There was a problem hiding this comment.
I think it improves code quality 👍
SDartayet
approved these changes
Nov 7, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
…est_util module (#5213) **Motivation** Stop having all the dummy() functions that create non-working components spread all around the code. **Description** This pr brings all test utils in the rpc crate into a single test_utils module, including all the dummy() functions that were spread all around the code. This pr only focuses in the rpc crate to tackle issue #5070 since it's the only one that had a test_utils module and required having a dummy instance of a component to be created for testing. Closes #5070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Stop having all the dummy() functions that create non-working components spread all around the code.
Description
This pr brings all test utils in the rpc crate into a single test_utils module, including all the dummy() functions that were spread all around the code.
This pr only focuses in the rpc crate to tackle issue #5070 since it's the only one that had a test_utils module and required having a dummy instance of a component to be created for testing.
Closes #5070