Skip to content

Conversation

@ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Nov 5, 2025

No description provided.

@ilitteri ilitteri self-assigned this Nov 5, 2025
@ilitteri ilitteri requested a review from a team as a code owner November 5, 2025 19:43
Copilot AI review requested due to automatic review settings November 5, 2025 19:43
@github-actions github-actions bot added the L2 Rollup client label Nov 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves logging consistency and adds performance timing measurements to the prover backend implementations. The changes standardize logging messages across SP1 and RISC0 backends and modernize string formatting syntax.

  • Adds execution time tracking for prove operations in both backends
  • Updates log messages to be more descriptive and consistent
  • Modernizes string formatting to use inline variable syntax

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/l2/prover/src/backend/sp1.rs Reorders imports, adds timing for prove operation, updates log messages to include execution duration with modern formatting
crates/l2/prover/src/backend/risc0.rs Adds timing for prove operation, updates log messages to be more descriptive and include execution duration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ilitteri ilitteri enabled auto-merge November 5, 2025 19:46
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Lines of code report

Total lines added: 4
Total lines removed: 0
Total lines changed: 4

Detailed view
+----------------------------------------------+-------+------+
| File                                         | Lines | Diff |
+----------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/backend/risc0.rs | 105   | +2   |
+----------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/backend/sp1.rs   | 128   | +2   |
+----------------------------------------------+-------+------+

@ilitteri ilitteri added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit 10f5a3d Nov 5, 2025
36 checks passed
@ilitteri ilitteri deleted the improve_zkvm_logs branch November 5, 2025 21:52
@github-project-automation github-project-automation bot moved this to Done in ethrex_l2 Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L2 Rollup client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants