fix(l1): fix queue length log #5197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
MegaRedHand
approved these changes
Nov 5, 2025
Collaborator
MegaRedHand
left a comment
MegaRedHand
left a comment
There was a problem hiding this comment.
LGTM. What a footgun!
jrchatruc
approved these changes
Nov 5, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** Currently the log incorrectly always shows max_queue_length as 0. **Description** The move closure takes ownership and mutates _a copy_ of the max_queue_length. This is fixed by taking the reference outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the log incorrectly always shows max_queue_length as 0.
Description
The move closure takes ownership and mutates a copy of the max_queue_length. This is fixed by taking the reference outside.