Skip to content

Conversation

@mpaulucci
Copy link
Collaborator

@mpaulucci mpaulucci commented Nov 4, 2025

Motivation
Users using ethrex don't really care where the module comes from.

Description

  • Removes the target if the log level is info or above
  • Refactors the init_tracing function to be clearer
  • Downgrades some logs

@mpaulucci mpaulucci requested a review from a team as a code owner November 4, 2025 17:59
Copilot AI review requested due to automatic review settings November 4, 2025 17:59
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Nov 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces logging verbosity by downgrading several frequently-occurring log messages from debug or info level to trace level, and improves the logging configuration setup. The changes help reduce noise in production logs while maintaining detailed information for deep debugging when needed.

Key changes:

  • Downgraded routine operational messages to trace level in transaction broadcasting, peer table management, and blockchain storage updates
  • Refactored tracing initialization to disable target display and simplify the color/profiling layer configuration
  • Added trace import to tx_broadcaster.rs to support the new log level

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/networking/p2p/tx_broadcaster.rs Downgraded broadcast operation logs to trace level and added trace import
crates/networking/p2p/discv4/peer_table.rs Downgraded peer table reset message to trace level
crates/blockchain/blockchain.rs Changed storage update log message from debug to trace with clearer wording
cmd/ethrex/initializers.rs Refactored tracing initialization for clarity, disabled target display, and simplified layer composition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Lines of code report

Total lines added: 0
Total lines removed: 1
Total lines changed: 1

Detailed view
+-----------------------------------+-------+------+
| File                              | Lines | Diff |
+-----------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs | 453   | -1   |
+-----------------------------------+-------+------+

@mpaulucci mpaulucci changed the title chore(l1,l2): disable printing of log tagets. chore(l1,l2): disable printing of log tagets depending on log level Nov 10, 2025
@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Nov 10, 2025
@ilitteri ilitteri enabled auto-merge November 10, 2025 17:57
@ilitteri ilitteri added this pull request to the merge queue Nov 10, 2025
@mpaulucci mpaulucci changed the title chore(l1,l2): disable printing of log tagets depending on log level chore(l1,l2): disable printing of log targets depending on log level Nov 10, 2025
Merged via the queue into main with commit ec91257 Nov 10, 2025
43 of 44 checks passed
@ilitteri ilitteri deleted the disable-printing-targets branch November 10, 2025 18:32
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 10, 2025
xqft pushed a commit that referenced this pull request Nov 11, 2025
…5184)

**Motivation**
Users using ethrex don't really care where the module comes from.

**Description**
- Removes the target if the log level is info or above
- Refactors the `init_tracing` function to be clearer
- Downgrades some logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants