-
Notifications
You must be signed in to change notification settings - Fork 130
chore(l1,l2): disable printing of log targets depending on log level #5184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reduces logging verbosity by downgrading several frequently-occurring log messages from debug or info level to trace level, and improves the logging configuration setup. The changes help reduce noise in production logs while maintaining detailed information for deep debugging when needed.
Key changes:
- Downgraded routine operational messages to
tracelevel in transaction broadcasting, peer table management, and blockchain storage updates - Refactored tracing initialization to disable target display and simplify the color/profiling layer configuration
- Added
traceimport to tx_broadcaster.rs to support the new log level
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/networking/p2p/tx_broadcaster.rs | Downgraded broadcast operation logs to trace level and added trace import |
| crates/networking/p2p/discv4/peer_table.rs | Downgraded peer table reset message to trace level |
| crates/blockchain/blockchain.rs | Changed storage update log message from debug to trace with clearer wording |
| cmd/ethrex/initializers.rs | Refactored tracing initialization for clarity, disabled target display, and simplified layer composition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lines of code reportTotal lines added: Detailed view |
…5184) **Motivation** Users using ethrex don't really care where the module comes from. **Description** - Removes the target if the log level is info or above - Refactors the `init_tracing` function to be clearer - Downgrades some logs
Motivation
Users using ethrex don't really care where the module comes from.
Description
init_tracingfunction to be clearer