perf(l1): avoid validating node hash #5167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
L1
Lines of code reportTotal lines added: Detailed view |
Benchmark for 138544eClick to view benchmark
|
Benchmark for cbfeb8eClick to view benchmark
|
Benchmark for dbf699eClick to view benchmark
|
Benchmark for 440276bClick to view benchmark
|
Benchmark Block Execution Results Comparison Against Main
|
Benchmark for 5890549Click to view benchmark
|
Benchmark for ac1bb65Click to view benchmark
|
Benchmark for 7e6a43fClick to view benchmark
|
Benchmark for 653028aClick to view benchmark
|
jrchatruc
approved these changes
Nov 3, 2025
pablodeymo
reviewed
Nov 4, 2025
crates/common/trie/node.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Gets a shared reference to the inner node. |
Contributor
There was a problem hiding this comment.
I would like to have an explicit doc telling the difference with get_node()
Benchmark for 50d3aadClick to view benchmark
|
Benchmark for 02d9500Click to view benchmark
|
pablodeymo
approved these changes
Nov 4, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** Currently when fetching a node during tree traversal, we compute it's hash to validate it. This isn't necessary when the trie is consistent. **Description** This adds a checked variant for use in snap sync (which requires reading from inconsistent tries) and removes hash validation from the others. --------- Co-authored-by: Javier Chatruc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when fetching a node during tree traversal, we compute it's hash to validate it. This isn't necessary when the trie is consistent.
Description
This adds a checked variant for use in snap sync (which requires reading from inconsistent tries) and removes hash validation from the others.