feat(l1,l2): support fusaka blobs cell_proofs #5121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 41ed5e7.
**Motivation** After Osaka, we (ethrex L2) as blob originators have to update our approach to constructing blob transactions (see [this](https://x.com/vdwijden/status/1978443940098457669?s=46&t=UeaOPcmE9dAwr9hxRE1oWQ)) and [include the cell blob proofs in the bundle](#4814). As a ZK rollup, in the guest program, we verify the blob construction, but the zkVM libraries lack working functionality for verifying blob cell proofs (we've created the following issues on SP1 and RISC0, respectively succinctlabs/kzg-rs#28 and risc0/risc0#3506). **Description** To avoid troubles with libraries, we opted to verify the blob the old-fashioned way (pre-Osaka-like) in the guest program. This can be done without any issue, since what's important in the guest program is to compute the same blob versioned hash as the one that was committed on the L1; how the blob is verified is independent of this. This PR reverts the changes done to the prover crate in pos of verifying cell proofs and updates the prover input generation to generate a single blob proof for the prover.
Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
Lines of code reportTotal lines added: Detailed view |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the Osaka fork's blob wrapper version feature, introducing logic to differentiate between Prague (wrapper version 0) and Osaka (wrapper version 1) fork behaviors for blob handling. The implementation includes timestamp-based fork detection, updates to blob proof generation, and configuration for Osaka activation time.
Key Changes
- Added
osaka_activation_timeconfiguration parameter to determine the active fork on L1 - Updated
BlobsBundle::create_from_blobs()to accept awrapper_versionparameter for generating appropriate blob proofs (KZG proofs for Prague, cell proofs for Osaka) - Modified
get_batch()method signature to accept aforkparameter throughout the codebase
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/networking/rpc/eth/client.rs | Made EthConfigResponse struct public |
| crates/networking/rpc/clients/eth/mod.rs | Added get_eth_config() method and wrapper_version field to Overrides |
| crates/networking/rpc/clients/eth/errors.rs | Added GetEthConfigError and fixed typo in UnreachableNonce |
| crates/networking/p2p/rlpx/l2/l2_connection.rs | Updated get_batch() call to include fork parameter |
| crates/l2/storage/src/store.rs | Modified get_batch() to accept fork parameter and set wrapper version based on fork |
| crates/l2/sequencer/l1_committer.rs | Added osaka_activation_time field and fork-aware proof generation logic |
| crates/l2/sequencer/errors.rs | Added MissingBlob error variant |
| crates/l2/sequencer/configs.rs | Added osaka_activation_time configuration field |
| crates/l2/sdk/src/sdk.rs | Added get_l1_active_fork() helper function and wrapper_version to transaction building |
| crates/l2/prover/src/guest_program/src/input.rs | Fixed blob_proof array initialization syntax |
| crates/l2/prover/src/guest_program/src/execution.rs | Fixed blob_proof comparison to use reference |
| crates/l2/networking/rpc/l2/batch.rs | Updated batch retrieval to include fork parameter |
| crates/l2/monitor/widget/batches.rs | Propagated osaka_activation_time and fork parameter through batch operations |
| crates/l2/monitor/app.rs | Added osaka_activation_time field to monitor widget |
| crates/l2/docker-compose.yaml | Added ETHREX_OSAKA_ACTIVATION_TIME environment variable |
| crates/l2/based/block_fetcher.rs | Added osaka_activation_time and fork-aware blob bundle generation |
| crates/l2/Makefile | Added osaka_activation_time configuration and comment |
| crates/common/types/transaction.rs | Added wrapper_version field to transaction structs |
| crates/common/types/blobs_bundle.rs | Implemented fork-aware blob creation with version validation and tests |
| crates/common/crypto/kzg.rs | Added blob_to_commitment_and_cell_proofs() function for Osaka |
| cmd/ethrex/l2/options.rs | Added osaka_activation_time CLI option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PROOF_COORDINATOR_ADDRESS?=127.0.0.1 | ||
| ETHREX_BLOCK_PRODUCER_OPERATOR_FEE_PER_GAS?=1000000000 \ | ||
| ETHREX_BLOCK_PRODUCER_OPERATOR_FEE_PER_GAS?=1000000000 | ||
| # Timestamp for Osaka activation in the hoodi. Sufficient to start network with Prague for tests. |
There was a problem hiding this comment.
Corrected spelling of 'hoodi' to 'Holesky' (or 'hood' if referring to a different network).
Suggested change
| # Timestamp for Osaka activation in the hoodi. Sufficient to start network with Prague for tests. | |
| # Timestamp for Osaka activation in the Holesky. Sufficient to start network with Prague for tests. |
Co-authored-by: Copilot <[email protected]>
ilitteri
approved these changes
Nov 1, 2025
jrchatruc
approved these changes
Nov 1, 2025
xqft
added a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** <!-- Why does this pull request exist? What are its goals? --> Reapply #4814 **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> --------- Co-authored-by: Tomás Paradelo <[email protected]> Co-authored-by: Tomás Paradelo <[email protected]> Co-authored-by: Gianbelinche <[email protected]> Co-authored-by: Estéfano Bargas <[email protected]> Co-authored-by: ilitteri <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reapply #4814
Description