fix(l1,l2): exclude ethrex-l2 crate make test
#5100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the test command in the Makefile to exclude the ethrex-l2 crate from the standard test run, along with an explanatory comment noting that this crate requires external setup not managed by the Makefile.
Key Changes
- Added comment explaining why
ethrex-l2crate exclusion is necessary - Modified
cargo testcommand to excludeethrex-l2crate from workspace tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ManuelBilbao
approved these changes
Oct 29, 2025
fedacking
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ethrex-l2tests are mainly integration tests that need a dev L1 to be up.Description
Exclude
ethrex-l2crate frommake test.