Skip to content

fix(l1): port 30303 still used after stopping the node #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrchatruc merged 2 commits into from
Oct 24, 2025
Merged

fix(l1): port 30303 still used after stopping the node #5041

jrchatruc merged 2 commits into from
Oct 24, 2025

Conversation

@edg-l
Copy link
Contributor

@edg-l edg-l commented Oct 24, 2025

Motivation

Closes #4895

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Lines of code report

Total lines added: 2
Total lines removed: 0
Total lines changed: 2

Detailed view 
+-----------------------------------------+-------+------+
| File                                    | Lines | Diff |
+-----------------------------------------+-------+------+
| ethrex/crates/networking/p2p/network.rs | 365   | +2   |
+-----------------------------------------+-------+------+

@edg-l edg-l changed the title Fix p2p port fix(l1): port 30303 still used after stopping the node Oct 24, 2025
@github-actions github-actions bot added the L1 Ethereum client label Oct 24, 2025
@edg-l edg-l marked this pull request as ready for review October 24, 2025 15:02
@edg-l edg-l requested a review from a team as a code owner October 24, 2025 15:02
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 24, 2025
Oppen
Oppen requested changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the bug by starting a node, killing it, and starting the node again.

@github-project-automation github-project-automation bot moved this from In Review to In Progress in ethrex_l1 Oct 24, 2025
Oppen
Oppen approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on ethrex-sync-2, killed and restarted 4 times without issue or waits.

@github-project-automation github-project-automation bot moved this from In Progress to In Review in ethrex_l1 Oct 24, 2025
@jrchatruc jrchatruc enabled auto-merge October 24, 2025 15:48
@jrchatruc jrchatruc added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 07dcec0 Oct 24, 2025
30 checks passed
@jrchatruc jrchatruc deleted the fix_p2p_port branch October 24, 2025 16:18
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oppen Oppen Oppen approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@edg-l edg-l

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port 30303 still used after stopping the node

4 participants

@edg-l @Oppen @jrchatruc