Skip to content

Conversation

@ManuelBilbao
Copy link
Contributor

Motivation

Committer is not always waking up after committer_wake_up_ms but commit_time_ms

Description

Change the delay time to wake up again

@ManuelBilbao ManuelBilbao self-assigned this Oct 23, 2025
Copilot AI review requested due to automatic review settings October 23, 2025 22:25
@ManuelBilbao ManuelBilbao requested a review from a team as a code owner October 23, 2025 22:25
@ManuelBilbao ManuelBilbao added the L2 Rollup client label Oct 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the L2 committer where it was waking up after the wrong time interval. Instead of using committer_wake_up_ms for scheduling the next wake-up, it was incorrectly using commit_time_ms, which could cause the committer to wake up at the wrong intervals.

Key Changes

  • Corrected the committer wake-up scheduling to use committer_wake_up_ms instead of commit_time_ms

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Lines of code report

Total lines added: 11
Total lines removed: 0
Total lines changed: 11

Detailed view
+--------------------------------------------+-------+------+
| File                                       | Lines | Diff |
+--------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_committer.rs | 795   | +11  |
+--------------------------------------------+-------+------+

Co-authored-by: Tomás Grüner <[email protected]>
Copy link
Contributor

@LeanSerra LeanSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ManuelBilbao ManuelBilbao added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit cf9276b Oct 24, 2025
28 checks passed
@ManuelBilbao ManuelBilbao deleted the fix_committer_wake_up branch October 24, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L2 Rollup client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants