-
Notifications
You must be signed in to change notification settings - Fork 131
fix(l2): committer wake up delay #5033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the L2 committer where it was waking up after the wrong time interval. Instead of using committer_wake_up_ms for scheduling the next wake-up, it was incorrectly using commit_time_ms, which could cause the committer to wake up at the wrong intervals.
Key Changes
- Corrected the committer wake-up scheduling to use
committer_wake_up_msinstead ofcommit_time_ms
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Lines of code reportTotal lines added: Detailed view |
Co-authored-by: Tomás Grüner <[email protected]>
LeanSerra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Motivation
Committer is not always waking up after
committer_wake_up_msbutcommit_time_msDescription
Change the delay time to wake up again