Skip to content

perf(l1, l2): use fxhash for diff layers #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrchatruc merged 3 commits into from
Oct 24, 2025
Merged

perf(l1, l2): use fxhash for diff layers #5032

jrchatruc merged 3 commits into from
Oct 24, 2025

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Oct 23, 2025 •
edited by jrchatruc
Loading

This PR replaces the hash function used for the diff layers hash map to improve performance

Motivation

Description

Closes #issue_number

@jrchatruc jrchatruc changed the title perf/fxhash for layers perf(l1, l2): use fxhash for diff layers Oct 23, 2025
@Oppen Oppen force-pushed the perf/fxhash_for_layers branch from 12c1b14 to 7fdc17a Compare October 23, 2025 21:41
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Lines of code report

Total lines added: 1
Total lines removed: 0
Total lines changed: 1

Detailed view 
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/trie_db/layering.rs | 139   | +1   |
+-------------------------------------------+-------+------+

@jrchatruc jrchatruc marked this pull request as ready for review October 23, 2025 22:45
@jrchatruc jrchatruc requested a review from a team as a code owner October 23, 2025 22:45
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client performance Block execution throughput and performance in general labels Oct 23, 2025
@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Oct 24, 2025
@jrchatruc jrchatruc added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 7a4b41b Oct 24, 2025
48 checks passed
@jrchatruc jrchatruc deleted the perf/fxhash_for_layers branch October 24, 2025 14:03
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in ethrex_performance Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edg-l edg-l edg-l approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

No one assigned

Labels

L1 Ethereum client L2 Rollup client performance Block execution throughput and performance in general

Projects

ethrex_l1
Status: Done
ethrex_l2
Status: Done
ethrex_performance
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Oppen @edg-l @jrchatruc