-
Notifications
You must be signed in to change notification settings - Fork 132
feat(l2): allow paying fees with custom token #5024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
177 commits
Select commit
Hold shift + click to select a range
93a5217
Revert "feat(l2): custom native token (#4622)"
tomip01 9c23130
add custom fee token tx
tomip01 e6890f9
first approach l2 hook
tomip01 c146fdb
basic custom fee token test, missing correctness
tomip01 934be30
some advances on test
tomip01 21b9f35
fix tx type check
tomip01 6ac9b51
change custom fee tx to 0xfd
tomip01 2e937ce
prevent recursion
tomip01 fce3ffc
some advances, exeuctin sol function, failing on acc updates
tomip01 36139db
succeeding internal hook txs
tomip01 d3f6ebd
working fees, failing eth value
tomip01 d7bd248
fix pks and sks
tomip01 6c8f05c
test passing with fee vault
tomip01 5a27a64
all working, missing LOTS of refactors
tomip01 3c230d7
correct based and native tokens changes
tomip01 2a778f9
more changes to workflow
tomip01 2d0fb42
restore contracts
tomip01 42b2f42
update address contract
tomip01 0392b9e
Merge branch 'main' into fee_token_2
tomip01 ac9f885
remove dbgs
tomip01 d2c5f97
Merge branch 'fee_token_2' into fee_token_3
tomip01 95cc43b
fix merge main on tests
tomip01 e4e5d14
some refactors, working
tomip01 923e6cc
fix coinbase diminish fee
tomip01 a215f25
l2 hook refactors
tomip01 d896d25
more refactors
tomip01 5c67a8d
refactor contracts
tomip01 51cd21e
refactor tests
tomip01 2db97e6
fix runner compile
tomip01 e8410af
add more pk
tomip01 dbbd0d8
update pk tests
tomip01 21da403
fix srialization
tomip01 71eb92d
fix runner compile again
tomip01 3232b7c
fix fees config update
tomip01 049d054
restore testing files
tomip01 9034b54
restore testing files again
tomip01 45fa41a
Merge branch 'main' into fee_token_2
tomip01 2048445
Merge branch 'fee_token_2' into fee_token_3
tomip01 119914b
Merge branch 'main' into fee_token_2
tomip01 a2050fa
Merge branch 'fee_token_2' into fee_token_3
tomip01 24603cd
refactor: le_hook
tomip01 7a42d76
fix compile test
tomip01 3034711
remove redundant if
tomip01 5be27cf
rename custom fee -> fee token
tomip01 2362379
fix renaming issue
tomip01 9814be2
remove empty hook
tomip01 89dcf58
merge and handle option types
tomip01 b743601
doc transfer fee_token
tomip01 be039ac
doc l2_hook
tomip01 749f2b1
add log and use var instead of hardcoded
tomip01 240f4b9
add log and use var instead of hardcoded fix
tomip01 6844c64
add vault checks
tomip01 ce6dfe1
fix vault checks
tomip01 f3811b4
use default hook explicit functions
tomip01 4441cfb
use IFeeToken and fix l2 dev job
tomip01 231ca50
add fee token docs
tomip01 61b616b
restore makefile
tomip01 9984753
remove step docs
tomip01 e304253
Merge branch 'main' into fee_token_2
tomip01 a217eff
review suggestions
tomip01 8f6f416
Merge branch 'fee_token_2' into fee_token_3
tomip01 f93245a
fix deployer
tomip01 9138917
Merge branch 'fee_token_2' into fee_token_3
tomip01 e45b0fe
fix default bridge address
tomip01 c2cb4c8
Merge branch 'fee_token_2' into fee_token_3
tomip01 a3d2f54
iclude fee token tx in p2p
tomip01 9fa147c
try fix based integration test
tomip01 b525115
Merge branch 'main' into fee_token_2
tomip01 e3e0a31
Merge branch 'fee_token_2' into fee_token_3
tomip01 2cb1c86
Merge branch 'main' into fee_token_2
tomip01 4410cc1
Merge branch 'fee_token_2' into fee_token_3
tomip01 a6b20e3
more detail docs
tomip01 a43e5c5
first approach on fee registry
tomip01 c888453
use restrict allowance for token registry
tomip01 85620b5
Update crates/vm/levm/src/hooks/l2_hook.rs
tomip01 4c67d94
make only base fee vault check optionals
tomip01 e4c0412
restore makefile
tomip01 38e6d03
Merge branch 'main' into fee_token_2
tomip01 7f50595
fix deafult address
tomip01 7b67f43
Merge branch 'fee_token_2' into fee_token_3
tomip01 b3e5696
add cargo lock
tomip01 37c6e7d
Merge branch 'main' into fee_token_2
tomip01 8e6ab6f
Merge branch 'fee_token_2' into fee_token_3
tomip01 960054b
Merge branch 'main' into fee_token_2
tomip01 4d0fcf2
fix: update default address
tomip01 885a0a7
Merge branch 'fee_token_2' into fee_token_3
tomip01 28f5d6f
fix merge main
tomip01 2be365d
refactor: use fixed address
tomip01 13ec266
refactor: remove old code
tomip01 452a134
restore genesis
tomip01 477927e
Revert "restore genesis"
tomip01 5d63a29
some advances, removing modifier on bridge works
tomip01 7e19fd6
missing working but fix some error
tomip01 ef3239b
working, removed debug stuff
tomip01 cac2f2d
add missing func
tomip01 406c59a
add step in deployer
tomip01 c7991b0
some advances, missing underprice
tomip01 59aa4bd
add secure check
tomip01 8e43c56
add fee token to default
tomip01 e7193fe
fix address
tomip01 8ccb56d
fix tests
tomip01 89ad9f2
update bridge owner
tomip01 278db2d
fix rule makefile
tomip01 611763d
fix address again
tomip01 ee1b353
revert wrong address
tomip01 34357eb
fix clippy
tomip01 1c26ae7
update fees accordingly
tomip01 b1d23e2
try test
tomip01 5a9d938
fix import
tomip01 0b94fbd
add await
tomip01 75a8c36
Merge branch 'main' into fee_token_2
tomip01 5aff987
Merge branch 'fee_token_2' of github.com:lambdaclass/ethrex into fee_…
tomip01 fd465af
Merge branch 'fee_token_2' into fee_token_3
tomip01 72abebb
fix compilation
tomip01 f536c57
fix lint
tomip01 0591d7c
increase wait time
tomip01 074333b
add dbg to show registry
tomip01 c57c8ab
fix compile
tomip01 6f8261d
fix
tomip01 76a38b5
more dbgs
tomip01 543d5a2
try option
tomip01 34055a2
try debugging waiting
tomip01 44391e8
add one more dbg print
tomip01 f113425
update genesis?
tomip01 a55b417
update test gas limit
tomip01 54392ea
try fix contract
tomip01 fe9e647
increase gas limit
tomip01 d019fe6
try removing modifier
tomip01 6895ca9
print receipt
tomip01 a9eb350
run all tests
tomip01 d9c5868
refactor test
tomip01 14f3b70
update ethrex version
tomip01 838879f
refactors and delete debug stuff
tomip01 88a2707
fix clippy
tomip01 486093d
add deprecated variable
tomip01 5f2e856
add contracts suggestions
tomip01 0937f21
correct contract formatting
tomip01 b44f39b
update: token docs
tomip01 f08c6bb
update again fee_token.md
tomip01 d91c68e
changes docs again
tomip01 54122db
fix default address
tomip01 2b64283
Merge branch 'fee_token_2' into fee_token_3
tomip01 ecb7b66
do initial registry inside deposits
tomip01 b1b27f6
fix docs
tomip01 f48cc88
Revert "do initial registry inside deposits"
tomip01 8de6da4
await for receipt inside deposits
tomip01 699c2df
add comment on expected value
tomip01 6c485b8
fix lint deployer
tomip01 07fff12
use correct function for waiting
tomip01 c20a999
fix lints
tomip01 74754de
add comment explaining
tomip01 9be4cbd
fix clippy
tomip01 1843454
fix clippy
tomip01 8cebd79
fix indentation
tomip01 d49b063
Update crates/l2/contracts/src/l2/FeeTokenRegistry.sol
tomip01 601f2b6
fix indent and add correct error msg
tomip01 cdfbce0
fix again sol contract indent
tomip01 5525beb
fix edge case
tomip01 421a94c
comment and remove old variable
tomip01 b58b602
apply suggestion
tomip01 fdbb270
fix deploy
tomip01 608916a
fix deployer again
tomip01 ec383f9
Merge branch 'main' into fee_token_3
tomip01 b474688
Update crates/l2/contracts/src/l2/FeeTokenRegistry.sol
tomip01 8b2cffc
remove old comment
tomip01 460f7fb
Update cmd/ethrex/l2/deployer.rs
tomip01 d9cea78
Update cmd/ethrex/l2/deployer.rs
tomip01 437dbde
fix lint
tomip01 fa4766b
Merge branch 'main' into fee_token_3
tomip01 25eebc2
Merge branch 'main' into fee_token_3
ilitteri 9453206
Merge branch 'main' into fee_token_3
tomip01 951f8e1
update blobs for reconstruct
tomip01 973d43b
fix test again
tomip01 ccfd67e
fix type
tomip01 3bfe660
fix compilation
tomip01 d4cb74d
update again the blobs
tomip01 5fc7b15
fix latest block of the batch reconstruction
tomip01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.