-
Notifications
You must be signed in to change notification settings - Fork 219
feat(l2): allow paying fees with custom token #5024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,643
−1,091
Merged
Changes from all commits
Commits
Show all changes
177 commits
Select commit
Hold shift + click to select a range
93a5217
Revert "feat(l2): custom native token (#4622)"
9c23130
add custom fee token tx
e6890f9
first approach l2 hook
c146fdb
basic custom fee token test, missing correctness
934be30
some advances on test
21b9f35
fix tx type check
6ac9b51
change custom fee tx to 0xfd
2e937ce
prevent recursion
fce3ffc
some advances, exeuctin sol function, failing on acc updates
36139db
succeeding internal hook txs
d3f6ebd
working fees, failing eth value
d7bd248
fix pks and sks
6c8f05c
test passing with fee vault
5a27a64
all working, missing LOTS of refactors
3c230d7
correct based and native tokens changes
2a778f9
more changes to workflow
2d0fb42
restore contracts
42b2f42
update address contract
0392b9e
Merge branch 'main' into fee_token_2
tomip01 ac9f885
remove dbgs
d2c5f97
Merge branch 'fee_token_2' into fee_token_3
95cc43b
fix merge main on tests
e4e5d14
some refactors, working
923e6cc
fix coinbase diminish fee
a215f25
l2 hook refactors
d896d25
more refactors
5c67a8d
refactor contracts
51cd21e
refactor tests
2db97e6
fix runner compile
e8410af
add more pk
dbbd0d8
update pk tests
21da403
fix srialization
71eb92d
fix runner compile again
3232b7c
fix fees config update
049d054
restore testing files
9034b54
restore testing files again
45fa41a
Merge branch 'main' into fee_token_2
tomip01 2048445
Merge branch 'fee_token_2' into fee_token_3
119914b
Merge branch 'main' into fee_token_2
tomip01 a2050fa
Merge branch 'fee_token_2' into fee_token_3
24603cd
refactor: le_hook
7a42d76
fix compile test
3034711
remove redundant if
5be27cf
rename custom fee -> fee token
2362379
fix renaming issue
9814be2
remove empty hook
89dcf58
merge and handle option types
b743601
doc transfer fee_token
be039ac
doc l2_hook
749f2b1
add log and use var instead of hardcoded
240f4b9
add log and use var instead of hardcoded fix
6844c64
add vault checks
ce6dfe1
fix vault checks
f3811b4
use default hook explicit functions
4441cfb
use IFeeToken and fix l2 dev job
231ca50
add fee token docs
61b616b
restore makefile
9984753
remove step docs
e304253
Merge branch 'main' into fee_token_2
tomip01 a217eff
review suggestions
8f6f416
Merge branch 'fee_token_2' into fee_token_3
f93245a
fix deployer
9138917
Merge branch 'fee_token_2' into fee_token_3
e45b0fe
fix default bridge address
c2cb4c8
Merge branch 'fee_token_2' into fee_token_3
a3d2f54
iclude fee token tx in p2p
9fa147c
try fix based integration test
b525115
Merge branch 'main' into fee_token_2
e3e0a31
Merge branch 'fee_token_2' into fee_token_3
2cb1c86
Merge branch 'main' into fee_token_2
4410cc1
Merge branch 'fee_token_2' into fee_token_3
a6b20e3
more detail docs
a43e5c5
first approach on fee registry
c888453
use restrict allowance for token registry
85620b5
Update crates/vm/levm/src/hooks/l2_hook.rs
tomip01 4c67d94
make only base fee vault check optionals
e4c0412
restore makefile
38e6d03
Merge branch 'main' into fee_token_2
7f50595
fix deafult address
7b67f43
Merge branch 'fee_token_2' into fee_token_3
b3e5696
add cargo lock
37c6e7d
Merge branch 'main' into fee_token_2
tomip01 8e6ab6f
Merge branch 'fee_token_2' into fee_token_3
960054b
Merge branch 'main' into fee_token_2
4d0fcf2
fix: update default address
885a0a7
Merge branch 'fee_token_2' into fee_token_3
28f5d6f
fix merge main
2be365d
refactor: use fixed address
13ec266
refactor: remove old code
452a134
restore genesis
477927e
Revert "restore genesis"
5d63a29
some advances, removing modifier on bridge works
7e19fd6
missing working but fix some error
ef3239b
working, removed debug stuff
cac2f2d
add missing func
406c59a
add step in deployer
c7991b0
some advances, missing underprice
59aa4bd
add secure check
8e43c56
add fee token to default
e7193fe
fix address
8ccb56d
fix tests
89ad9f2
update bridge owner
278db2d
fix rule makefile
611763d
fix address again
ee1b353
revert wrong address
34357eb
fix clippy
1c26ae7
update fees accordingly
b1d23e2
try test
5a9d938
fix import
0b94fbd
add await
75a8c36
Merge branch 'main' into fee_token_2
5aff987
Merge branch 'fee_token_2' of github.com:lambdaclass/ethrex into fee_…
fd465af
Merge branch 'fee_token_2' into fee_token_3
72abebb
fix compilation
f536c57
fix lint
0591d7c
increase wait time
074333b
add dbg to show registry
c57c8ab
fix compile
6f8261d
fix
76a38b5
more dbgs
543d5a2
try option
34055a2
try debugging waiting
44391e8
add one more dbg print
f113425
update genesis?
a55b417
update test gas limit
54392ea
try fix contract
fe9e647
increase gas limit
d019fe6
try removing modifier
tomip01 6895ca9
print receipt
a9eb350
run all tests
d9c5868
refactor test
14f3b70
update ethrex version
tomip01 838879f
refactors and delete debug stuff
88a2707
fix clippy
486093d
add deprecated variable
5f2e856
add contracts suggestions
0937f21
correct contract formatting
b44f39b
update: token docs
f08c6bb
update again fee_token.md
d91c68e
changes docs again
54122db
fix default address
2b64283
Merge branch 'fee_token_2' into fee_token_3
ecb7b66
do initial registry inside deposits
b1b27f6
fix docs
f48cc88
Revert "do initial registry inside deposits"
8de6da4
await for receipt inside deposits
699c2df
add comment on expected value
6c485b8
fix lint deployer
07fff12
use correct function for waiting
c20a999
fix lints
74754de
add comment explaining
9be4cbd
fix clippy
1843454
fix clippy
tomip01 8cebd79
fix indentation
d49b063
Update crates/l2/contracts/src/l2/FeeTokenRegistry.sol
tomip01 601f2b6
fix indent and add correct error msg
cdfbce0
fix again sol contract indent
5525beb
fix edge case
421a94c
comment and remove old variable
b58b602
apply suggestion
fdbb270
fix deploy
608916a
fix deployer again
ec383f9
Merge branch 'main' into fee_token_3
b474688
Update crates/l2/contracts/src/l2/FeeTokenRegistry.sol
tomip01 8b2cffc
remove old comment
460f7fb
Update cmd/ethrex/l2/deployer.rs
tomip01 d9cea78
Update cmd/ethrex/l2/deployer.rs
tomip01 437dbde
fix lint
fa4766b
Merge branch 'main' into fee_token_3
25eebc2
Merge branch 'main' into fee_token_3
ilitteri 9453206
Merge branch 'main' into fee_token_3
tomip01 951f8e1
update blobs for reconstruct
973d43b
fix test again
ccfd67e
fix type
tomip01 3bfe660
fix compilation
d4cb74d
update again the blobs
5fc7b15
fix latest block of the batch reconstruction
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.