-
Notifications
You must be signed in to change notification settings - Fork 146
refactor(l1)!: unify trie node encoding #4995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark for 92d3498Click to view benchmark
|
Benchmark for 496cefbClick to view benchmark
|
MegaRedHand
reviewed
Oct 23, 2025
MegaRedHand
reviewed
Oct 23, 2025
Benchmark for 400bea5Click to view benchmark
|
MegaRedHand
approved these changes
Oct 23, 2025
Collaborator
MegaRedHand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jrchatruc
approved these changes
Oct 23, 2025
Benchmark for 6c048b7Click to view benchmark
|
Benchmark for 315eb52Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This changes the format of nodes in the DB. You will need to re-sync your node.
Motivation
Currently, we have two ways of encoding a node: by specifying the node type (encode_to_vec, used for storing) and by letting the decoder infer it (encode_raw, used for hashing).
This causes confusion and prevents from making use of the RLP's API ability to decode onto an existing buffer.
Also by unifying the formats used for storing and hashing we can avoid encoding the same node twice.
Description
Unifies RLP encodings used for database and hashing.
Helps with #4956