Skip to content

fix(l1): fix big account download stopping prematurely #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fedacking merged 6 commits into from
Oct 24, 2025
Merged

fix(l1): fix big account download stopping prematurely #4994

fedacking merged 6 commits into from
Oct 24, 2025

Conversation

@fedacking
Copy link
Contributor

@fedacking fedacking commented Oct 22, 2025 •
edited
Loading

Motivation

There was a bug that was prematurely marking big accounts as done, causing inconsistent behaviour in the downloads of these accounts. This PR aims to fix the bug

Description

  • When we receive a "should continue" in verify_range the task result will include the account as done in the remaining_start field. We changed the logic of marking accounts done to check that no intervals remain.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Lines of code report

Total lines added: 6
Total lines removed: 0
Total lines changed: 6

Detailed view 
+----------------------------------------------+-------+------+
| File                                         | Lines | Diff |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/peer_handler.rs | 1758  | +6   |
+----------------------------------------------+-------+------+

@fedacking fedacking changed the title Fix big account download stopping prematurely fix(l1): fix big account download stopping prematurely Oct 24, 2025
@github-actions github-actions bot added the L1 Ethereum client label Oct 24, 2025
@fedacking fedacking marked this pull request as ready for review October 24, 2025 14:29
@fedacking fedacking requested a review from a team as a code owner October 24, 2025 14:29
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 24, 2025
@fedacking fedacking added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit c9b0005 Oct 24, 2025
36 checks passed
@fedacking fedacking deleted the fix-big-account-download-stopping-prematurely branch October 24, 2025 16:06
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@fedacking fedacking

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fedacking @mpaulucci @jrchatruc