Skip to content

Conversation

@fedacking
Copy link
Contributor

Motivation

Snapsync logs had a series of issues:

  • The storage leaves counter was showing the the storage accounts that were inserted.
  • The initially accounts with storage, healed account log is not meaningful for users, only for developers.
  • The logs included ascii color codes that didn't work due to tracing subscriber 0.3.20

Description

  • Added log of storage_leaves_inserted/storage_leaves_downloaded %
  • Removed logs of initially accounts with storage, healed account
  • Removed Peers and Database unused ascii color code
  • Removed unused storage_tries_state_roots_computed

Contributes to issue #4950

@github-actions github-actions bot added the L1 Ethereum client label Oct 21, 2025
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Lines of code report

Total lines added: 15
Total lines removed: 21
Total lines changed: 36

Detailed view
+----------------------------------------------+-------+------+
| File                                         | Lines | Diff |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/metrics.rs      | 593   | +4   |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/network.rs      | 367   | +4   |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/peer_handler.rs | 1759  | +7   |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync.rs         | 1335  | -21  |
+----------------------------------------------+-------+------+

@fedacking fedacking marked this pull request as ready for review October 21, 2025 21:40
@fedacking fedacking requested a review from a team as a code owner October 21, 2025 21:40
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 21, 2025
@jrchatruc jrchatruc added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 9f7443c Oct 24, 2025
30 checks passed
@jrchatruc jrchatruc deleted the improved-snapync-logs branch October 24, 2025 16:55
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants