-
Notifications
You must be signed in to change notification settings - Fork 130
chore(l1,l2): made so that the P2P logging functions say the correct file #4971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Waiting until base branch |
Lines of code reportTotal lines added: Detailed view |
|
Updated the branch and marked ready for review as |
|
Did you try using |
It doesn't seem to work on my testing with |
Motivation
The logs in P2P use 4 utility function to log what the peer did. (
log_peer_debug, log_peer_error, log_peer_trace, log_peer_warn) These functions obscure which file triggered the log in the tracing macros. Changing those functions to macros, changes this behaviour to show the proper file. Example:2025-10-20T21:27:08.447426Z ERROR ethrex_p2p::rlpx::utils: reth/[0xddd9…df1e(194.233.75.31:30303)]: Broken pipe with peer, disconnected2025-10-20T21:34:24.178984Z ERROR ethrex_p2p::rlpx::connection::server: reth/[0x6101…3c5f(54.87.135.143:30303)]: Broken pipe with peer, disconnectedDescription
log_peer_*functions withlog_peer_*!macros, doing the same functionality.