fix(l1): remove duplicate span.entered() call in apply_updates #4970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a duplicate tracing span entry in the apply_updates function. The removed span.entered() call was redundant, causing the same tracing span to be entered twice unnecessarily.
- Removed duplicate
tracing::trace_span!("Block DB update").entered()call
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
MegaRedHand
commented
Oct 20, 2025
| ], | ||
| )?; | ||
|
|
||
| let _span = tracing::trace_span!("Block DB update").entered(); |
Collaborator
Author
There was a problem hiding this comment.
Note that before calling open_cfs there's another line like this.
Lines of code reportTotal lines added: Detailed view |
pablodeymo
approved these changes
Oct 20, 2025
rodrigo-o
approved these changes
Oct 20, 2025
jrchatruc
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the numbers we get from grafana seem to be weird. This might have been caused by a duplicate span that was created in
apply_updates. I suspect it was from a git conflict that was solved erroneously.Description
This PR removes a duplicate span
entered()call.