Skip to content

Conversation

@MegaRedHand
Copy link
Collaborator

Motivation

Main was broken due to L2 linting job. Also, and unused dependency was introduced in the latest commit.

Description

This PR removes the unused import causing the CI error, along with the unused ethrex-trie dependency on the ethrex package.

@MegaRedHand MegaRedHand requested a review from a team as a code owner October 19, 2025 00:05
Copilot AI review requested due to automatic review settings October 19, 2025 00:05
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Oct 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactor to fix linting errors and remove an unused dependency.

  • Remove unused rocksdb::DBCommon import in tests to resolve CI linting failure.
  • Drop unused ethrex-trie dependency from the ethrex binary crate.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
crates/storage/trie_db/rocksdb.rs Removes unused DBCommon import from rocksdb test module.
cmd/ethrex/Cargo.toml Removes unused ethrex-trie workspace dependency from the ethrex binary crate.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MegaRedHand MegaRedHand enabled auto-merge October 20, 2025 11:37
@MegaRedHand MegaRedHand added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit 87ed562 Oct 20, 2025
33 checks passed
@MegaRedHand MegaRedHand deleted the fix-lint-remove-unused-deps branch October 20, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants