-
Notifications
You must be signed in to change notification settings - Fork 131
fix(l1, l2): cargo test compilation at workspace level #4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| [workspace] | ||
| members = [ | ||
| "benches", | ||
| "cmd/ethrex", | ||
| "crates/blockchain", | ||
| "crates/blockchain/dev", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| [package] | ||
| name = "ethrex-benches" | ||
| version.workspace = true | ||
| edition.workspace = true | ||
| authors.workspace = true | ||
| documentation.workspace = true | ||
|
|
||
| [dependencies] | ||
| ethrex.workspace = true | ||
| ethrex-blockchain.workspace = true | ||
| ethrex-common.workspace = true | ||
| ethrex-config.workspace = true | ||
| ethrex-storage.workspace = true | ||
|
|
||
| bytes.workspace = true | ||
| tokio.workspace = true | ||
| serde_json.workspace = true | ||
|
|
||
| [dev-dependencies] | ||
| criterion = { version = "0.5.1", features = [ | ||
| "html_reports", | ||
| "async_futures", | ||
| "async_tokio", | ||
| ] } | ||
| secp256k1.workspace = true | ||
| tempfile.workspace = true | ||
| ethrex-l2-rpc.workspace = true | ||
|
|
||
| [[bench]] | ||
| name = "build_block_benchmark" | ||
| harness = false |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -103,7 +103,7 @@ impl ValueFormatter for GasMeasurementFormatter { | |||||
| } | ||||||
|
|
||||||
| fn read_private_keys() -> Vec<SecretKey> { | ||||||
| let file = include_str!("../../../fixtures/keys/private_keys_l1.txt"); | ||||||
| let file = include_str!("../../fixtures/keys/private_keys_l1.txt"); | ||||||
| file.lines() | ||||||
| .map(|line| { | ||||||
| let line = line.trim().strip_prefix("0x").unwrap(); | ||||||
|
|
@@ -122,7 +122,7 @@ async fn setup_genesis(accounts: &Vec<Address>) -> (Store, Genesis) { | |||||
| if std::fs::exists(&storage_path).unwrap_or(false) { | ||||||
|
||||||
| if std::fs::exists(&storage_path).unwrap_or(false) { | |
| if storage_path.path().exists() { |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cwd should point to the crate root (where Cargo.toml resides). The benches crate root is benches, not benches/benches. Update to cwd: 'benches' so cargo bench runs correctly.