feat(l1): implement flatkeyvalue (snapshots) #4884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 175de2d.
Benchmark for f8a1effClick to view benchmark
|
Benchmark for 7462ef0Click to view benchmark
|
Benchmark for cc00a65Click to view benchmark
|
Benchmark for 483cbafClick to view benchmark
|
Benchmark for fe41120Click to view benchmark
|
Oppen
approved these changes
Oct 18, 2025
Contributor
Oppen
left a comment
Oppen
left a comment
There was a problem hiding this comment.
There are a few minor comments. I'll make an issue with them. Otherwise it should be good to go.
Comment on lines
+154
to
+156
| if path.len() == 32 { | ||
| self.pending_removal.insert(Nibbles::from_bytes(path)); | ||
| } |
Contributor
There was a problem hiding this comment.
This is not true for all tries (receipts, transactions and withdrawals use their index encoded as RLP as key), but also at this level Trie is just key-value. This should be unconditional.
| pub fn get(&self, pathrlp: &PathRLP) -> Result<Option<ValueRLP>, TrieError> { | ||
| let path = Nibbles::from_bytes(pathrlp); | ||
|
|
||
| if pathrlp.len() == 32 |
Contributor
There was a problem hiding this comment.
Similarly, we shouldn't have to check length here.
Comment on lines
+112
to
+114
| pub const CF_FLATKEYVALUE: &str = "flatkeyvalue"; | ||
|
|
||
| pub const CF_MISC_VALUES: &str = "misc_values"; |
| }; | ||
| let account_state = AccountState::decode(&node.value)?; | ||
| let account_hash = H256::from_slice(&path.to_bytes()); | ||
| batch.put_cf(&cf_misc, "last_written", path.as_ref()); |
Contributor
There was a problem hiding this comment.
We may save some memory and some overhead by miving the last_written updates to inside the if ctr > 10_000 cases.
Comment on lines
+749
to
+751
| let ret = db | ||
| .write(batch) | ||
| .map_err(|e| StoreError::Custom(format!("RocksDB batch write error: {}", e))); |
Contributor
There was a problem hiding this comment.
Missing comment explaining we need to unconditionally run the lines below, and that they are order sensitive.
Comment on lines
+73
to
+75
| if let Node::Leaf(leaf) = node.as_ref() { | ||
| acc.push((path.concat(&leaf.partial), leaf.value.clone())); | ||
| } |
Contributor
There was a problem hiding this comment.
We should have a comment here.
Benchmark for e84c87aClick to view benchmark
|
Benchmark for a155d2eClick to view benchmark
|
Benchmark for 9731dacClick to view benchmark
|
ManuelBilbao
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to have a way to query values directly without going through the trie (several reads).
To do this, we have a flattened key=>value mapping, which we call FlatKeyValue. This is sometimes known as "snapshots".
Description
A process is launched to generate this mapping in the background. We ensure
apply_updatesand this process don't conflict, and that block execution can only make use of the calculated snapshots.Closes #1997, closes #2409, closes #2410