Skip to content

feat(l1): add block building metric #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edg-l merged 2 commits into from
Oct 15, 2025
Merged

feat(l1): add block building metric #4878

edg-l merged 2 commits into from
Oct 15, 2025

Conversation

@edg-l
Copy link
Contributor

@edg-l edg-l commented Oct 15, 2025

Motivation

Currently missing.

@edg-l edg-l requested a review from a team as a code owner October 15, 2025 09:44
@github-actions github-actions bot added the L1 Ethereum client label Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Lines of code report

Total lines added: 32
Total lines removed: 0
Total lines changed: 32

Detailed view 
+----------------------------------------------------+-------+------+
| File                                               | Lines | Diff |
+----------------------------------------------------+-------+------+
| ethrex/crates/blockchain/metrics/metrics_blocks.rs | 104   | +27  |
+----------------------------------------------------+-------+------+
| ethrex/crates/blockchain/payload.rs                | 665   | +5   |
+----------------------------------------------------+-------+------+

Arkenan
Arkenan approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Oct 15, 2025
@edg-l edg-l added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit e06ea7b Oct 15, 2025
30 checks passed
@edg-l edg-l deleted the add_block_building_metric branch October 15, 2025 11:52
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 15, 2025
@edg-l edg-l mentioned this pull request Oct 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2025
@edg-l
chore(l1): register block building metric and dashboard (#4879)
7c234d6 
**Motivation**
In #4878 we forgot to register the metric so prometheus picks it up

<img width="2220" height="338" alt="image"
src="https://github.com/user-attachments/assets/83d24e97-9d68-41b3-88f6-cd0fdfb8d626"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arkenan Arkenan Arkenan approved these changes

@azteca1998 azteca1998 azteca1998 approved these changes

Assignees

@edg-l edg-l

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edg-l @Arkenan @azteca1998