-
Notifications
You must be signed in to change notification settings - Fork 131
chore(l1): move FD limit before storage initialization #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a startup issue where the node fails to restart after being stopped during sync by moving the file descriptor (FD) limit setting before storage initialization.
- Move
raise_fd_limit()?call from after metrics initialization to before storage setup - Ensures FD limits are properly configured before any storage operations that might require file handles
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This was the log after starting an already synced node: Now, they are working |
Pull Request is not mergeable
Motivation
We were setting the FD limit after the storage initialization, which made the node unable to start if we stopped it after a sync.
Description
Just move the FD limit before the storage setup