-
Notifications
You must be signed in to change notification settings - Fork 130
fix(l1): modify Grafana dashboards so they can be filtered by instance #4831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The instance filter has a regex to avoid having to choose from each prometheus target: `server:port` and instead just filter by `server` and let it choose the port according to the different metric each pane needs to check
|
I see this is actively being worked on. Converting to draft, please convert to review once its ready |
|
Apart for adding support for multiple servers (instances) to be able to compare different runs, the dashboard had major improvements:
This still have some points to address in follow up PRs here are 2 issues that we need to tackle:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the Grafana dashboards to support filtering metrics by instance using a regex pattern. The main improvement allows users to filter by server name (e.g., ethrex-mainnet-3-0-0) instead of requiring the full server:port format, with the regex automatically matching the appropriate port for each metric.
Key changes:
- Modified instance filter variable to use regex pattern
/^(?<text>[^:]+)(?::\\d+)?$/for extracting server names - Updated metric queries across all dashboards to use
instance=~\"$instance(:\\\\d+)?$\"pattern - Converted several stat panels to table format for better multi-instance visualization
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ethrex_l1_perf.json | Updated instance filtering with regex, converted stat panels to tables, reorganized dashboard layout with new sections |
| ethrex_comparison.json | New dashboard added for comparing ethrex performance against other Ethereum clients across different networks |
| ethereum_metrics_exporter.json | Updated instance filtering with regex, converted stat panels to tables for multi-instance support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This PR also added a new dashboard intended for internal use, comparing some instances of other clients in the same panel. |
#4831) **Motivation** The Ethrex L1 Perf grafana dashboard currently doesn't let us filter by instance, it only works as a standalone dashboard for 1 ethrex instance. **Description** The instance filter now has a regex to avoid having to choose from each prometheus target: `server:port` and instead just filter by `server` and let it choose the port according to the different metric each pane needs to check --------- Co-authored-by: Rodrigo Oliveri <[email protected]>


Motivation
The Ethrex L1 Perf grafana dashboard currently doesn't let us filter by instance, it only works as a standalone dashboard for 1 ethrex instance.
Description
The instance filter now has a regex to avoid having to choose from each prometheus target:
server:portand instead just filter byserverand let it choose the port according to the different metric each pane needs to checkCloses #4976