feat(l1): snap sync optimizations #4777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for d960b58Click to view benchmark
|
Benchmark for 27e30deClick to view benchmark
|
Benchmark for a5dd3a7Click to view benchmark
|
+ linting
Benchmark for 822ad39Click to view benchmark
|
Benchmark for 932000dClick to view benchmark
|
Benchmark for 6ac36c3Click to view benchmark
|
Benchmark for 9739147Click to view benchmark
|
mpaulucci
reviewed
Oct 7, 2025
| ] | ||
| metrics = ["ethrex-blockchain/metrics", "ethrex-l2/metrics"] | ||
| rocksdb = ["ethrex-storage/rocksdb"] | ||
| rocksdb = ["ethrex-storage/rocksdb", "ethrex-p2p/rocksdb"] |
Collaborator
There was a problem hiding this comment.
Can't we avoid coupling p2p with the specific db implementation?
Contributor
There was a problem hiding this comment.
I agree. A priori is not that easy to decouple it, and we need these optimizations. I'll file an issue to tackle this.
Contributor
There was a problem hiding this comment.
@fedacking, please file the issue to tackle this.
MegaRedHand
reviewed
Oct 7, 2025
Comment on lines
+1511
to
+1512
| for (account_hash, account) in account_states_snapshot { | ||
| trie.insert(account_hash.0.to_vec(), account.encode_to_vec())?; |
Collaborator
There was a problem hiding this comment.
This is missing calls to the metrics module. The "inserting accounts" progress stays at 0% even when we're past that stage.
MegaRedHand
approved these changes
Oct 7, 2025
ilitteri
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR reintroduces the optimizations reverted in #4734, now fixed. There were two problems with it:
Description
Closes #issue_number