perf(l1): improve block headers vec handling in syncer#4771
Merged
Conversation
github-actions
Bot
added
L1
edg-l
marked this pull request as ready for review
October 6, 2025 09:19
edg-l
changed the title
Lines of code reportTotal lines added: Detailed view |
Benchmark Block Execution Results Comparison Against Main
|
Oppen
approved these changes
Oct 6, 2025
Peponks9
pushed a commit
to Peponks9/ethrex
that referenced
this pull request
Oct 7, 2025
) **Motivation** Currently, in snap and full sync we remove the first header from the vec because we already have it, this is quite wasteful specially on a Vec where removing the first element is the most expensive. **Description** Converted process_incoming_headers to take an owned iterator instead, this way we avoid any copy, also in full sync changed the clone and clear into a single mem take, which both clears and returns the owned vec to be used as an iterator. Also avoided some clones when passing block hashes around in store block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, in snap and full sync we remove the first header from the vec because we already have it, this is quite wasteful specially on a Vec where removing the first element is the most expensive.
Description
Converted process_incoming_headers to take an owned iterator instead, this way we avoid any copy, also in full sync changed the clone and clear into a single mem take, which both clears and returns the owned vec to be used as an iterator.
Also avoided some clones when passing block hashes around in store block