-
Notifications
You must be signed in to change notification settings - Fork 130
test(l1): polish test reports with timestamps and formatting #4770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(l1): polish test reports with timestamps and formatting #4770
Conversation
- Move reports to reports/ directory with automatic creation - Add timestamps to report filenames (YYYY-MM-DD_HH-MM-SS) - Improve failure report readability using prettytable-rs - Add make clean-reports command to delete all reports - Update .gitignore to exclude reports/ directory
JereSalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that one report is being generated per test? get_report_paths() gets a new timestamp when called. Wouldn't that generate a ton of files if we run all the tests? Maybe it would be better to have less files.
If you have them could you provide an example of success and failure report so that everybody can see the final result in the PR? Thanks
Alright, thanks. |
I just updated it to generate single timestamped report per test run. |
|
Hi @JereSalo , you can check it out. |
JereSalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. It looks great. I'll upload an example of a failure report so that other reviewers can see what it looks like without them having to run it.
failure_report_2025-10-14_13-56-27.txt
Thank you for this
Alright |
Motivation
The EF state tests runner currently generates reports in the root directory with static filenames (
success_report.txtandfailure_report.txt), which makes it difficult to track different test runs and compare results over time. Additionally, failure reports useplain text formatting that can be hard to read when debugging test failures.
Description
This PR polishes the test reports for the EF state tests runner by implementing the following improvements:
reports/directory that is automatically created if it doesn't existYYYY-MM-DD_HH-MM-SS(e.g.,failure_report_2025-10-03_14-30-45.txt), making it easy to identify and compare different test runsprettytable-rsto display test information and errors in formatted tables, significantly improving readabilitymake clean-reportscommand to easily delete all generated reportsreports/directory to prevent generated reports from being committedThese changes make it easier to debug failing EF tests by providing better-organized, timestamped, and more readable reports.
Closes #3886