feat(l2): implement operator fee #4725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 40948ec.
JereSalo
reviewed
Oct 16, 2025
crates/vm/backends/levm/mod.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub fn claculate_gas_price_for_tx( |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn claculate_gas_price_for_tx( | |
| pub fn calculate_gas_price_for_tx( |
tomip01
reviewed
Oct 21, 2025
crates/vm/backends/levm/mod.rs
Outdated
| env.block_gas_limit = i64::MAX as u64; // disable block gas limit | ||
|
|
||
| adjust_disabled_base_fee(&mut env); | ||
| adjust_disabled_base_fee(&mut env, &mut vm_type); |
Contributor
There was a problem hiding this comment.
Instead of receive a mutable VMType, we could create a new one with the same config but the fee_operator in case gas_price is 0. That seems a bit cleaner
ManuelBilbao
approved these changes
Oct 23, 2025
ilitteri
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce a new fee type:
operator fee.It behaves like the base fee (multiplied by the gas used) and is sent to the operator fee vault.
I suggest reading
transaction_fees.mdbefore reviewing the PR.Closes #4694