feat(l2): aligned mode support for multiprover #3429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark for e722057Click to view benchmark
|
ManuelBilbao
requested changes
Oct 24, 2025
crates/l2/common/src/prover.rs
Outdated
| pub fn aligned_vm_program_code(&self) -> std::io::Result<Option<Vec<u8>>> { | ||
| match self { | ||
| Self::RISC0 => { | ||
| let path = format!( |
Contributor
There was a problem hiding this comment.
This won't work on downloaded binaries. We should embed this in the binary. For reference, here's a way to do it:
https://github.com/lambdaclass/ethrex/pull/4014/files#diff-a73d7b3e1eec2d556992a25ceef5203288ab90a0f9bcc7b4a176a754c647dc42R72
github-project-automation
bot
moved this from In Review
to Requires Changes
in ethrex_l2
Benchmark for f9cc2c1Click to view benchmark
|
Benchmark for cd6e2acClick to view benchmark
|
Benchmark for ec31811Click to view benchmark
|
Benchmark for 8331720Click to view benchmark
|
Benchmark for d9b5491Click to view benchmark
|
Benchmark for 20dee03Click to view benchmark
|
Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
Benchmark for bd8ebd1Click to view benchmark
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2025
**Motivation** #3429 updated how SP1 verification key generation works, but the tag_release workflow was not updated to take this into account.
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** #3429 updated how SP1 verification key generation works, but the tag_release workflow was not updated to take this into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds support for Aligned + multi-prover, in particular supporting both SP1 and Risc0. This is a big change that requires modifying the sequencer, prover and settlement contracts.
Also fixes some bugs discovered on the way (SP1 public inputs, SQL rollup store, prover make rules). More details in description.
Description
store_latest_sent_batch_proofnot workinginit-proverandbuild-proverrules not working for GPUgpufeature instead of relying in theSP1_PROVERenv var (to make it consistent with Risc0)