perf(l1): reduce transaction clone and Vec grow overhead in mempool#2637
Merged
Conversation
Lines of code reportTotal lines added: Detailed view |
edg-l
added
the
performance
Contributor
Author
|
some local bench load tests Specs: Commands main (33e34ef) PR #2637 (9eb253e) |
Benchmark Block Execution Results Comparison Against Main
|
Contributor
Author
|
Using load-test-erc20 main: Load test finished. Elapsed time: 433 seconds main |
Oppen
approved these changes
Apr 30, 2025
rodrigo-o
approved these changes
May 6, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 7, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 7, 2025
edg-l
enabled auto-merge
May 7, 2025 11:37
fmoletta
pushed a commit
that referenced
this pull request
May 15, 2025
…2637) **Motivation** Improve perfomance **Description** Reduces transaction clone overhead on the mempool and Vec initial grow overhead. The main focus on this pr was the mempool fetch transaction method whose overhead before was 15%~, reducing it to 13%~, whose main time is spent in the filter transaction method, which had a clone taking 5% of the time now reduced to non existent levels using an Arc. Images of the perf profile: Before  After  <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…ambdaclass#2637) **Motivation** Improve perfomance **Description** Reduces transaction clone overhead on the mempool and Vec initial grow overhead. The main focus on this pr was the mempool fetch transaction method whose overhead before was 15%~, reducing it to 13%~, whose main time is spent in the filter transaction method, which had a clone taking 5% of the time now reduced to non existent levels using an Arc. Images of the perf profile: Before  After  <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes #issue_number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve perfomance
Description
Reduces transaction clone overhead on the mempool and Vec initial grow overhead.
The main focus on this pr was the mempool fetch transaction method whose overhead before was 15%
, reducing it to 13%, whose main time is spent in the filter transaction method, which had a clone taking 5% of the time now reduced to non existent levels using an Arc.Images of the perf profile:
Before
After
Closes #issue_number