perf(core): make TrieDb use NodeHash as key#2517
Merged
Merged
Conversation
Lines of code reportTotal lines added: Detailed view |
Benchmark for 2e3a2f5Click to view benchmark
|
edg-l
added
the
performance
Benchmark for 7152460Click to view benchmark
|
Benchmark for 2175d70Click to view benchmark
|
Benchmark for 9cd8507Click to view benchmark
|
Benchmark for 6a27f32Click to view benchmark
|
Benchmark for db5c22bClick to view benchmark
|
Benchmark for b6e9237Click to view benchmark
|
Benchmark Block Execution Results Comparison Against Main
|
mpaulucci
approved these changes
Apr 24, 2025
Benchmark for 80b48c4Click to view benchmark
|
Benchmark for c5fb698Click to view benchmark
|
jrchatruc
approved these changes
Apr 30, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Followup on lambdaclass#2516 using the fact that NodeHash is Copy to use it as the key for the trie db instead of a Vec **Description** Changes the trait TrieDb to use a NodeHash as key instead of a generic vec, allowing less expensive clones when passing around keys since NodeHash is copy and doesn't do any allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Followup on #2516 using the fact that NodeHash is Copy to use it as the key for the trie db instead of a Vec
Description
Changes the trait TrieDb to use a NodeHash as key instead of a generic vec, allowing less expensive clones when passing around keys since NodeHash is copy and doesn't do any allocation.