Skip to content

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jul 12, 2024

Motivation

Being able to serialize blocks matching the output required by the rpc spec

Description

*Add struct BlockSerializable which can be serialized to match the specifications of the rpc. It can contain either the full transactions or just their hashes.
*Implement serialization for BlockSerializable, BlockHeader, BlockBody, Withdrawal and Transaction.
Other changes:
*Replace Bloom with ethereum_types::Bloom
*Rename some fields in Eip1559Transaction to match other transaction types' fields

Closes None, but is needed in order to implement #31

@fmoletta fmoletta changed the title [WIP] serialize block feat: add block serialization Jul 15, 2024
@fmoletta fmoletta marked this pull request as ready for review July 15, 2024 19:40
@fmoletta fmoletta requested a review from a team as a code owner July 15, 2024 19:40
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmoletta fmoletta merged commit b8bd7fc into main Jul 16, 2024
@fmoletta fmoletta deleted the block-serializable branch July 16, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants