feat: extend Store api with block functionality
#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElFantasma
reviewed
Jul 12, 2024
crates/storage/src/libmdbx.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn store_and_fetch_block() { |
Contributor
There was a problem hiding this comment.
Does it make sense to move tests to crate/storage/src/lib just as test_store_account?
That way we'll have tests for all Engine implementations right away
MegaRedHand
pushed a commit
that referenced
this pull request
Jul 17, 2024
…m libmdx impl of store (#150) Based on #146, please merge it first **Motivation** Add a way to fetch blocks from their hashes (as blocks are stored by number this translates to adding a block_hash -> block_number mapping) <!-- Why does this pull request exist? What are its goals? --> **Description** * Add `get_block_number` & `add_block_number` methods to `Store` (both using block_hash as key) * Remove unwraps from libmdx impl of `Store` <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes None, but is needed in order to implement #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to store and fetch blocks from the db via
StoreapiDescription
Transaction::encodewithTransaction::encode_with_typelogic (Reasoning: We cannot decode the transactions without knowing their type with the current behaviour, making it impossible to implementRLPDecodeforTransaction)RLPDecodeforTransaction(Using the logic that was previoulsy used inEncodedTransaction::decode(payload module))RLPDecodeforWithdrawal,BlockHeaderandBlockBodyStoreandStoreEngine:add_block_header,add_block_body,get_block_header,get_block_body, and implement them forInMemoryandLibmdbxengine typesCloses None, but is needed for #145