Provide heartbeat support for healthchecking periodic services#12
Merged
Conversation
There is little need for it, and the new heartbeat admin would require lots of compatbility code for these unsupported releases. * django.templatetags.static.static() just prefixes STATIC_IRL in 1.8/1.9 * Admin icons would require GIFs in 1.8. * Tests would need MIDDLEWARE_CLASSES
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 85.35% 91.98% +6.63%
==========================================
Files 5 9 +4
Lines 157 262 +105
Branches 23 30 +7
==========================================
+ Hits 134 241 +107
+ Misses 19 16 -3
- Partials 4 5 +1
Continue to review full report at Codecov.
|
The public API is found in django_healthchecks.heartbeats, checks are added in `django_healthchecks.contrib`. This makes sure the underlying model implementation doesn't need to be touched by external callers.
Member
|
Cool :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds heartbeat support.
Feel free to comment on the object naming, suggest API changes, etc..