Added second name and flag parsing as false to Flag #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commander/ArgumentDescription.swift
Outdated
Owner
There was a problem hiding this comment.
After thinking about this for a while, I'd rather call this disabledName and disabledFlag. Would you be able to change the name to this?
Can you keep the old order intact so that the flag is after the original name, as follows:
init(_ name: String, flag: Character? = nil, disabledName: String? = nil, disabledFlag: Character? = nil, description: String? = nil, `default`: Bool = false)
Owner
|
Thanks for these changes @valentinknabel, I've had some feedback in the comments but otherwise this looks good. Would you be able to address these changes and then squash them into one commit and this should be good to merge. |
kylef
added a commit
that referenced
this pull request
Nov 6, 2015
Added second name and flag parsing as false to Flag
Owner
|
Thanks @valentinknabel, I've released this in Commander 0.3.0. |
Contributor
Author
|
Thanks @kylef for Commander. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed these changes because I wanted
--publicand--privateinstead of--no-public.